1554148 - The "Re-install" button in not positioned correctly on some of the locale

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P1)

Description

[Oana Botisan, Desktop QA]

Attachment: pic1.png

Affected versions

• Nightly 69.0a1

Affected platforms

• Windows 7 x32
• Windows 10 x64

Steps to reproduce

1. Install latest Nightly with the locale French build.
2. Uninstall Nightly.
3. Then install it again.

Expected result

• On the Re-install prompt the text and the "Re-install" button are correctly displayed.

Actual result

• The "Re-install" button overlays the text beneath it.

Regression range

• I think this is a recent regression brought by the new changes to the UI.

Additional notes

• This happens on other locales which have the text "Firefox Nightly has been installed before. Let's get you a new copy" taking more then three rows on the prompt, like ru, be builds.

Comment 1

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1554148 - Keep the profile cleanup button from rendering too low in the window. r=agashlin

The official layout had this same problem, so this just causes the mechanism
that was added to solve it there to also be invoked for every other branding.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce2f3736ddf9
Keep the profile cleanup button from rendering too low in the window. r=agashlin

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/ce2f3736ddf9

Comment 4

[Oana Botisan, Desktop QA]

I verified the fix using latest Nightly 70.0a1 on Windows 10 x64 and Windows 7 x32. The issue is not reproducing anymore.