Closed Bug 1554165 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16995 - [LayoutNG] Ignore fragmentation properties when not fragmenting.

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 16995 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16995
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

[LayoutNG] Ignore fragmentation properties when not fragmenting.

When we're not fragmenting, we shouldn't touch any of the fragmentation
related values in the container builder.

Added DCHECKs that would fail without this fix (and that will catch any
similar problems in the future at an earlier stage).

Bug: 966369
Change-Id: I8f6300435e211086fea8ea381912ad595e9a91ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628707
Commit-Queue: Emil A Eklund \<eae@chromium.org>
Reviewed-by: Emil A Eklund \<eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663051}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Failed to get results from try push
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4f82900ec2d
[wpt PR 16995] - [LayoutNG] Ignore fragmentation properties when not fragmenting., a=testonly

https://hg.mozilla.org/mozilla-central/rev/d4f82900ec2d

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream error] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.