1554238 - Remove `richlistitem` and `category` bindings

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P5)

Description

[alexander :surkov (:asurkov)]

when all UI stuff of about:addons are done (bug 1505924), then remove richlistbox.xml and extensions.xml bindings which are no longer in use:

• remove https://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/content/extensions.xml
• remove -moz-binding style from https://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/content/extensions.css#13
• remove https://searchfox.org/mozilla-central/source/toolkit/content/widgets/richlistbox.xml
• remove document uri check when defining a richlistitem custom element from https://searchfox.org/mozilla-central/source/toolkit/content/widgets/richlistbox.js

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1554238 - Remove 'richlistitem' and 'category' bindings.

Comment 2

[Tim Nguyen :ntim]

Well, the minimal changes I've planned unfortunately require string ID changes.
This will also be the case when rewriting this to HTML, so I guess I'll let that happen instead to avoid having to change the string ID twice :/

Anyway, if anyone wants to finish this off, the patch is attached.

Comment 3

[Andrew Swan [:aswan]]

Mark, is there any compelling reason to actually convert the category list to HTML? richlistbox is a xul custom element, so with this patch about:addons will be xbl free and won't be blocking any immediate de-xul work. Should we just finish this patch as-is and move on?

Comment 4

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1b069265f7208872eb50d16fdb4f96ebf0b16bb

Comment 5

[Mark Striemer [:mstriemer]]

I don't think it needs to be converted to HTML here.

Comment 6

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a174c7443182c95599432512307aaf21052538b2

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6d99b3e8e87
Remove 'richlistitem' and 'category' bindings. r=aswan

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c6d99b3e8e87