Closed
Bug 1554247
Opened 5 years ago
Closed 5 years ago
Fix warnings for "readability-braces-around-statements" in layout/painting/
Categories
(Core :: Web Painting, task, P3)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla69
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: mikokm, Assigned: cbrewster)
References
Details
Attachments
(2 files)
I have attached a list of warnings found by running mach static-analysis check --checks "readability-braces-around-statements" layout/painting.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → cbrewster
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Attachment #9068170 -
Attachment description: Bug 1554247 - Fix bracing in layout/painting → Bug 1554247 - Fix bracing in layout/painting r?miko
|
Reporter | |
Comment 2•5 years ago
|
||
Thank you for the patch Connor!
In order to get this landed, I recommend you run some tests (just reftests should be fine) on try server. If the try run looks green, you can land the patch by using Lando, or by adding checkin-needed keyword on this bug.
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•5 years ago
|
||
Here are my try runs on Treeherder: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4767a607e13df2b5d9a9820437186a20ed7afa9a
I believe the P oranges are unrelated
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b687c0536929
Fix bracing in layout/painting r=miko
Keywords: checkin-needed
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in
before you can comment on or make changes to this bug.
Description
•