Closed Bug 1554247 Opened 4 months ago Closed 4 months ago

Fix warnings for "readability-braces-around-statements" in layout/painting/

Categories

(Core :: Web Painting, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: miko, Assigned: cbrewster)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

I have attached a list of warnings found by running mach static-analysis check --checks "readability-braces-around-statements" layout/painting.

Assignee: nobody → cbrewster
Attachment #9068170 - Attachment description: Bug 1554247 - Fix bracing in layout/painting → Bug 1554247 - Fix bracing in layout/painting r?miko

Thank you for the patch Connor!

In order to get this landed, I recommend you run some tests (just reftests should be fine) on try server. If the try run looks green, you can land the patch by using Lando, or by adding checkin-needed keyword on this bug.

Status: NEW → ASSIGNED

Here are my try runs on Treeherder: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4767a607e13df2b5d9a9820437186a20ed7afa9a
I believe the P oranges are unrelated

Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.