155430 - Cannot print mail with attachments

Status: VERIFIED FIXED

(MailNews Core :: Printing, defect)

Description

[Cavin Song]

This is spun off bug 155189 whose patch is to prevent the program from crashing 
(and some of the attachments, like www.cnn.com, still can't be printed).

This bug is filed to continue finding the real cause of the problem.

Comment 1

[Cavin Song]

Adding ADT2 to the whiteboard.

Comment 2

[rods (gone)]

Attachment: patch

The problem is the print for a mail msg is started when the first notification
of the document (mail msg) is done loading. This is wrong because if the mail
msg has attachments they may not be loaded and then the msgPrintEngine gets
additional notification for when the attachments have started to load and since
it has already started toprint error dialogs appear AND the attachments don't
get printed.

The solution here is to cache a pointer to the DOM Window for the msg(s) being
printed. Then as the "stop" notifications come in we can ignore any documents
(which would be the attachments) where the dom window doesn't match the msg's
dom window. Then when they match which is the last notifiaction we can call
print.

The notification that comes thru where the docLoader is NULL means the previous
document has completed printing and the engine should print the next msg.

Comment 3

[scottputterman]

Let's get this reviewed.  If it passes review, I'd like to see this checked into
the trunk today so it can be verified on Monday for possible inclusion in the
branch.

Comment 4

[Cavin Song]

Comment on attachment 90088 [details] [diff] [review]
patch

r=cavin. I've tested the patch against a few msgs with various attachment typs
and it works well. Thanks for the fix.

Comment 5

[kinmoz]

Comment on attachment 90088 [details] [diff] [review]
patch

sr=[e-mail]

Comment 6

[(not reading, please use [e-mail] instead)]

sr=sspitzer as well.

from my aim converation with rod:

Q:  "when do we release the reference to mMsgDOMWin?  is it when the print
engine goes away?  I just want to make sure we don't hold on to it."
A:  "Yes, it ends up being the same window and same reference for each msg that
is printed.  The destructor does get called, I checked it in the debugger"

Comment 7

[rods (gone)]

fixed on trunk

Comment 8

[scottputterman]

Esther, can you verify this on the trunk on Monday?

Comment 9

[esther]

Yes, I take a trunk now and check it out.

Comment 10

[esther]

Using trunk build 20020708 on winxp, I did a send page of cnn.com and aol.com,
retrieved them and printed them. Both printed OK with no crash or hang or
strange error messages.  I checked other types of attachments by printing a msg
with attached .jpg, .gif, .doc and .xls and it printed OK too.  I also printed
page 1 to 1 and even though it only printed page 1, the printer spit out a blank
page for page 2. I need to see if this is a new bug. AND, the print dialog takes
5-6 seconds to come up when prining a mail message with attachments.  Not sure
if this is slower than previous build, I will check. 
Still need to check linux and mac for the crash.

Comment 11

[rods (gone)]

I am not sure about page 2 being blank....

The slowness in the Print Dialog is that now it has to wait until everything has
been loaded before it can display the Print Dialog, where before it waited only
until the msg was loaded and NOT the attachments.

In the future there will be a dialog that displays to show that something is
happening.

Comment 12

[esther]

Using trunk build 20020708 on linux, cnn.com and aol.com sent pages print OK,
however after one time priniting aol.com, sent by Send Page from a winxp system,
trying to print anything else afterwards gives an error "You can't print while
in print preview".  This does not happen when I print the cnn.com or
netscape.com pages sent from winxp.  This does not happen with 6.2.3 release
build.  This does not happen with the aol.com sent from a linux system using
Send Page.  This may be a different bug, I'll  log a new one for this.

Comment 13

[esther]

The 2nd page mentioned in comment #10 only happens when I print a  mail message
with cnn.com as an attachment so that's not a big deal.  Other pages seem fine,
a  5 page bug that was attached to a mail message prints only 1 page and does
not add a blank page.  Basically, WinXP is OK, no crash and mail messages with
attachments do print.

Mac 9.1 is basically OK. I am seeing a random problems printing the msg with
aol.com attached that may not be due to the fix in this bug.  I see the 3rd time
printing the printed page is missing part of the content or the system locks up
needing a force quit.  But these may be part of bug 118795, I will investigate
and log a new bug if necessary.  One more test to do on Mac OS10.1 

Comment 14

[esther]

Mac OS 10.1 is working ok too. Prints mail message with aol.com, cnn.com
attached.  Prints message with one .jpg, .gif, .doc and .xls attached. 

Also note: Linux problem mentioned above does not happen with new profile and
same messages.  

Verifying fixed on trunk can be checked into branch

Comment 15

[scottputterman]

adding adt1.0.1+.  Please get drivers approval before checking into the branch.

Comment 16

[chris hofmann]

Comment on attachment 90088 [details] [diff] [review]
patch

a=chofmann for 1.0.1  add the fixed1.0.1 keyword after checking into the branch

Comment 17

[rods (gone)]

fixed on branch

Comment 18

[esther]

FYI.. found out cause of linux problem in comment 12, logged bug 156385.

Comment 19

[esther]

Using branch build 20020709 on winxp, mac 9.1, linux and mac 10.1 and 3 mail
messages. 1 with aol.com attached, 1 with cnn.com attached and one with .jpg,
.gif, .doc, .xls attahced they all print fine, no crashes no printing error
messages, no partial printing. I will retest this on the branch builds that
includes the fix for 155189 before I verify it.

Comment 20

[esther]

Using branch build 20020715 on winxp, mac 9.1 and linux which now includes the
fix for 155189,  printing the same messages as mentioned above in comment 7-9
this is still OK.  All messages printed and there were no crashes, error
messages or hangs. Verified.