TEST-UNEXPECTED-FAIL | testAlarmDefaultValue.js

RESOLVED FIXED in 7.1

Status

task
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: mkmelin, Assigned: benjamin)

Tracking

(Blocks 1 bug, Regression, {regression})

unspecified
Dependency tree / graph

Details

(Whiteboard: [Thunderbird-testfailure: Z all][Thunderbird-disabled-test])

Attachments

(1 attachment, 1 obsolete attachment)

This now gives
SUMMARY-UNEXPECTED-FAIL | testAlarmDefaultValue.js | testAlarmDefaultValue.js::testDefaultAlarms
EXCEPTION: mouseEvent: could not find element ID: newMsgButton-calendar-menuitem
at: controller.jsm line 465

See bug 1547233 comment 1. The menu item doesn't exist anymore, and it's difficult to bring it back.

Could be fixed by clicking the menus or by the hotkeys. Ctrl + I, Ctrl + D for task

Keywords: regression
Regressed by: 1547233
Keywords: leave-open
Whiteboard: [Thunderbird-testfailure: Z all][Thunderbird-disabled-test]
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/bb7fbb8a0405
temporarily disable testAlarmDefaultValue.js::testDefaultAlarms. rs=bustage-fix

Over to Benjamin.

To trigger the Ctrl + I command in the mozmill test, use something like this: https://searchfox.org/comm-central/rev/2ddfe0d5bd910e7e7bdbdebb5b826b4863dfd880/mail/test/mozmill/composition/test-multipart-related.js#102

To test, re-enable the test and then
cd obj-*
make mozmill-one -C comm/calendar/test/mozmill/ SOLO_TEST=testAlarmDefaultValue.js

Assignee: nobody → benjamin
Posted patch bug-1554300.patch (obsolete) — Splinter Review

replaced click events for:
newMsgButton-task-menuitem and newMsgButton-calendar-menuitem with keypress events. All tests pass as expected.

Attachment #9069389 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 9069389 [details] [diff] [review]
bug-1554300.patch

Review of attachment 9069389 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK apart from some white-space nits.

::: calendar/test/mozmill/testAlarmDefaultValue.js
@@ +36,4 @@
>      collector.getModule("content-tab-helpers").setupModule();
>  }
>  
> +

Please don't add a blank line, the line should just be removed.

@@ +56,4 @@
>      openLightningPrefs(handlePrefTab, controller);
>  
>      // Create New Event.
> +    controller.keypress(null, "i", {shiftKey: false, accelKey: true}); 

Trailing space.

@@ +75,4 @@
>      });
>  
>      // Create New Task.
> +    controller.keypress(null, "d", {shiftKey: false, accelKey: true}); 

And here.

And please always run the linter, there were errors:
40:11 error 'eid' is assigned a value but never used. Allowed unused vars must match /(MODULE_NAME|MODULE_REQUIRES|RELATIVE_ROOT|setupModule|installInto|teardownTest|^test[A-Z_].*)/. no-unused-vars (eslint)
58:36 error A space is required after '{'. object-curly-spacing (eslint)
58:68 error A space is required before '}'. object-curly-spacing (eslint)
77:36 error A space is required after '{'. object-curly-spacing (eslint)
77:68 error A space is required before '}'. object-curly-spacing (eslint)

? 5 problems (5 errors, 2 warnings)

Keywords: leave-open

Patch for checkin with white-space correction and linting issues fixed.

Attachment #9069389 - Attachment is obsolete: true
Attachment #9069389 - Flags: review?(mkmelin+mozilla)
Attachment #9069574 - Flags: review+

And please configure you mercurial.ini so that your e-mail address is automatically included in the HG header.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/100447ecdcb2
Adapt testAlarmDefaultValue.js after bug 1547233. Navigate menu via keypress. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 7.1
You need to log in before you can comment on or make changes to this bug.