1554300 - TEST-UNEXPECTED-FAIL | testAlarmDefaultValue.js

Status: RESOLVED FIXED

(Calendar :: General, task)

Description

[Magnus Melin [:mkmelin]]

This now gives
SUMMARY-UNEXPECTED-FAIL | testAlarmDefaultValue.js | testAlarmDefaultValue.js::testDefaultAlarms
EXCEPTION: mouseEvent: could not find element ID: newMsgButton-calendar-menuitem
at: controller.jsm line 465

See bug 1547233 comment 1. The menu item doesn't exist anymore, and it's difficult to bring it back.

Could be fixed by clicking the menus or by the hotkeys. Ctrl + I, Ctrl + D for task

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bb7fbb8a0405
temporarily disable testAlarmDefaultValue.js::testDefaultAlarms. rs=bustage-fix

Comment 2

[Intermittent Failures Robot]

1 failures in 4730 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform breakdown:

• macosx1010-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1554300&startday=2019-05-20&endday=2019-05-26&tree=all

Comment 3

[Magnus Melin [:mkmelin]]

Over to Benjamin.

To trigger the Ctrl + I command in the mozmill test, use something like this: https://searchfox.org/comm-central/rev/2ddfe0d5bd910e7e7bdbdebb5b826b4863dfd880/mail/test/mozmill/composition/test-multipart-related.js#102

To test, re-enable the test and then
cd obj-*
make mozmill-one -C comm/calendar/test/mozmill/ SOLO_TEST=testAlarmDefaultValue.js

Comment 4

[Benjamin Flanagin]

Attachment: bug-1554300.patch

replaced click events for:
newMsgButton-task-menuitem and newMsgButton-calendar-menuitem with keypress events. All tests pass as expected.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9069389 [details] [diff] [review]
bug-1554300.patch

Review of attachment 9069389 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK apart from some white-space nits.

::: calendar/test/mozmill/testAlarmDefaultValue.js
@@ +36,4 @@
>      collector.getModule("content-tab-helpers").setupModule();
>  }
>  
> +

Please don't add a blank line, the line should just be removed.

@@ +56,4 @@
>      openLightningPrefs(handlePrefTab, controller);
>  
>      // Create New Event.
> +    controller.keypress(null, "i", {shiftKey: false, accelKey: true}); 

Trailing space.

@@ +75,4 @@
>      });
>  
>      // Create New Task.
> +    controller.keypress(null, "d", {shiftKey: false, accelKey: true}); 

And here.

Comment 6

[Jorg K (CEST = GMT+2)]

And please always run the linter, there were errors:
40:11 error 'eid' is assigned a value but never used. Allowed unused vars must match /(MODULE_NAME|MODULE_REQUIRES|RELATIVE_ROOT|setupModule|installInto|teardownTest|^test[A-Z_].*)/. no-unused-vars (eslint)
58:36 error A space is required after '{'. object-curly-spacing (eslint)
58:68 error A space is required before '}'. object-curly-spacing (eslint)
77:36 error A space is required after '{'. object-curly-spacing (eslint)
77:68 error A space is required before '}'. object-curly-spacing (eslint)

? 5 problems (5 errors, 2 warnings)

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: bug-1554300.patch

Patch for checkin with white-space correction and linting issues fixed.

Comment 8

[Jorg K (CEST = GMT+2)]

And please configure you mercurial.ini so that your e-mail address is automatically included in the HG header.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/100447ecdcb2
Adapt testAlarmDefaultValue.js after bug 1547233. Navigate menu via keypress. r=jorgk