1554302 - Cannot go back after navigating to main process pages (e.g. about: pages)

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

After navigating to main process pages like about:config, the back button doesn't work in GVE and Fenix. onCanGoBack returns false.

This is important because WebExtension pages run in the main process and are affected by this.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

This is the mozregression for about:config, looks like it has never worked:

7:09.00 INFO: Last good revision: 0dd3fef17f153feec51df058785579dcdeb91d83
7:09.00 INFO: First bad revision: 7131a22bb5e73218aa244df81feb14704ac0481d
7:09.00 INFO: Pushlog:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0dd3fef17f153feec51df058785579dcdeb91d83&tochange=7131a22bb5e73218aa244df81feb14704ac0481d

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Probably e10s related per Randall and Agi. (Randall confirmed FxR works, e10s off)

Comment 3

[Christian Sadilek [:csadilek]]

Just adding that we're running into this after calling browser.tabs.update. The tab is correctly updated, but it's no longer possible to navigate in history. Worth noting that subsequent browser.tabs.update calls also do not work, which seems related. If it it's not, please let me know and I'll file a separate issue.

Comment 4

[Chris Peterson [:cpeterson]]

Emily is investigating. This bug is a problem for Fenix's about:reader pages.

Comment 5

[Chris Peterson [:cpeterson]]

Emily says Agi will pick this bug up next week.

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

Looks like Desktop solves this problem by restoring history after every process switch. So I'm just going to do that on mobile too.

Comment 7

[Chris Peterson [:cpeterson]]

Fenix MVP is going to release with or without this fix, so it's not technically a Fenix MVP blocker. I'll move this bug to the next Fenix milestone (M7).

Comment 8

[Chris Peterson [:cpeterson]]

This bug blocks a Fenix issue related to zooming and converting A-C's Reader View extension to an extension page: https://github.com/mozilla-mobile/fenix/issues/2633

Comment 9

[Chris Peterson [:cpeterson]]

Deferring this bug to Q4. Agi understands the problem, but the solution is tricky and would take a couple months. Agi recommends we wait for the Fission team to implement async history (which we can use without enabling Fission).

@ Agi, do you know the bug # for Fission's async history work? Is it meta bug 1467221: "Fission Session History Work"?

Comment 10

[[ex-Mozilla] Agi Sferro | :agi]

I believe that is the correct bug to watch for.

Comment 11

[Chris Peterson [:cpeterson]]

Tentatively adding to GV's December sprint.

Comment 12

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1554302 - Restore state when switching process.

Comment 13

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1554302 - Restore history when switching process during navigation.

Comment 14

[juraj.masiar]

I'm not sure it's related but in the current beta 74.0b3 (64-bit), when you open any addon page, then manually change URL to any http page, you won't be able to navigate back to the addon page. This often happens if you use some addon to override your new tab page.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8bcd715e7b1
Restore history when switching process during navigation. r=snorp

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a8bcd715e7b1