1554311 - Start page timeout timer only after the test tab has actually been updated

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement, P1)

Description

[Robert Wood [:rwood]]

Currently the Raptor page timeout alarm/timer is set just before the test tab is updated with the test URL (ext.tabs.update call).

Instead, Raptor should await for the ext.tabs.update call itself to finish, and then at that time start the timeout timer. That way the elapsed time won't include the actual time for th eext.tabs.update call to finish; the timer will only measure the elapsed time it takes to actually get the performance measurements from the page content.

I am thinking that this may reduce Raptor intermittent page timeouts. Try this out and see how it effects timeouts etc.

Comment 1

[Robert Wood [:rwood]]

Will capture the onerror (promise returned by ext.tabs.update) so if the tab update call itself fails then Raptor can force a timeout/end the test.

Note: Must check if this is compatible with Chromium.

Comment 2

[Robert Wood [:rwood]]

Attachment: Bug 1554311 - Start page timeout timer only after the test tab has actually been updated

Comment 3

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e234ddd49844efd283ed64cd7eb250ac8b9a258

Comment 4

[Robert Wood [:rwood]]

Andrew, any thoughts about this potential patch? I'm thinking it may reduce some variability in the page timeout timer and ultimately reduce intermittent page timeouts (but not 100% sure; will do a bunch of try pushes to see if seems to have any effect).

Comment 5

[Andrew Creskey [:acreskey]]

Rob, I like this idea and I agree that it could make this step more deterministic.
Very curious as to how it behaves, but I think it's a better approach regardless.

Comment 6

[Robert Wood [:rwood]]

Thanks Andrew! Unfortunately Chromium doesn't return a promise for chrome.tabs.update. However both Firefox and Chromium support a callback in the x.tabs.update call, so I'll try starting the page timeout timer only after that callback is invoked.

Comment 7

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6642b9e159479d49dd19edcc67f52b5d12d49710

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cae42dee59f
Start page timeout timer only after the test tab has actually been updated r=acreskey

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/7cae42dee59f