1554326 - geckoview-only perma-fail services/common/tests/unit/test_uptake_telemetry.js | xpcshell return code: 0

Status: RESOLVED FIXED

(GeckoView :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: gbrown [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=248020253&repo=try
Full log: https://queue.taskcluster.net/v1/task/MvCAUqJ-S5e7-a0MO9Jw7A/runs/0/artifacts/public/logs/live_backing.log

---

When Android xpcshell is run against the geckoview apk, some tests fail -- this is one of them.

Comment 1

[Geoff Brown [:gbrown]]

This fails because geckoview sets toolkit.telemetry.eventping.enabled=false:

https://searchfox.org/mozilla-central/rev/4606c7974a68cab416c038acaedcae49eed93822/mobile/android/app/geckoview-prefs.js#19

Then events are discarded at:

https://searchfox.org/mozilla-central/rev/4606c7974a68cab416c038acaedcae49eed93822/toolkit/components/telemetry/core/TelemetryEvent.cpp#475

Comment 2

[Geoff Brown [:gbrown]]

Setting toolkit.telemetry.eventping.enabled=true resolves this test failure as well as several other geckoview-only xpcshell test failures in services/common and toolkit/components/telemetry.

Comment 3

[Intermittent Failures Robot]

1 failures in 4730 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• android-em-7-0-x86_64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1554326&startday=2019-05-20&endday=2019-05-26&tree=all

Comment 4

[Geoff Brown [:gbrown]]

Attachment: Bug 1554326 - Always set toolkit.telemetry.eventping.enabled during unit tests; r=snorp

This pref defaults to true, but geckoview builds set it to false. Several tests assume
this pref is set; some android xpcshell tests currently fail when run against the geckoview apk
for this reason. Setting the pref in the test profile means that geckoview tests will run
with a different pref value than geckoview would normally use, but aligns the geckoview
test environment with firefox. (An alternative would be to skip geckoview tests that rely
on the pref.)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99683e1207c4
Always set toolkit.telemetry.eventping.enabled during unit tests; r=snorp

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/99683e1207c4

Comment 7

[Chris Peterson [:cpeterson]]

Geoff, should we uplift this test pref fix to GV 69 Beta? Or are these xpcshell tests not running for GV 69 Beta?

Comment 8

[Geoff Brown [:gbrown]]

Currently all xpcshell tests run against the fennec apk, even on trunk (bug 1553225), even on Android 7.0 x86_64: There's more work to do before we can run against the geckoview apk and take advantage of this pref change. I think we can let this ride the trains.

Comment 9

[Geoff Brown [:gbrown]]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99683e1207c4
Always set toolkit.telemetry.eventping.enabled during unit tests; r=snorp

This is not working! Telemetry-dependent tests still fail against geckoview builds. If I make the same pref change in mobile/android/app/geckoview-prefs.js, tests pass.

Comment 10

[Geoff Brown [:gbrown]]

I updated the wrong profile directory!

Comment 11

[Geoff Brown [:gbrown]]

Attachment: Bug 1554326 - Always set toolkit.telemetry.eventping.enabled during xpcshell tests; r=snorp

My previous attempt updated the wrong test profile, which does not apply to xpcshell tests.
This applies the pref override to xpcshell tests only, the only place we need it.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d71845cdab45
Always set toolkit.telemetry.eventping.enabled during xpcshell tests; r=snorp

Comment 13

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/d71845cdab45