1554377 - Cleanup nsCookie implementation

Status: RESOLVED FIXED

(Core :: Networking: Cookies, task, P2)

Description

[Andrea Marchesini [:baku]]

Currently we have basically the same data struct with 4 different implementations:

1. nsCookie - used for nsICookie and nsICookie2 interfaces
   https://searchfox.org/mozilla-central/rev/4606c7974a68cab416c038acaedcae49eed93822/netwerk/cookie/nsCookie.h

2. nsCookieAttributes - used for cookie parsing
   https://searchfox.org/mozilla-central/rev/4606c7974a68cab416c038acaedcae49eed93822/netwerk/cookie/nsCookieService.h#203

3. ConstCookie - used mainly for 1 method only
   https://searchfox.org/mozilla-central/rev/4606c7974a68cab416c038acaedcae49eed93822/netwerk/cookie/nsCookieService.h#92

4. CookieStruct - used for IPC
   https://searchfox.org/mozilla-central/rev/4606c7974a68cab416c038acaedcae49eed93822/netwerk/ipc/NeckoChannelParams.ipdlh

We should have 1 implementation only. I pick CookieStruct.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1554377 - Cleanup nsCookie implementation - Get rid of ConstCookie, r?ehsan

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1554377 - Cleanup nsCookie implementation - Get rid of nsCookieAttributes, r?ehsan

Depends on D32560

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1554377 - Cleanup nsCookie implementation - simpler nsCookie, r?ehsan

Depends on D32561

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 1554377 - Cleanup nsCookie implementation - network.cookie.thirdparty.sessionOnly to StaticPrefs, r?ehsan

Depends on D32562

Comment 5

[Andrea Marchesini [:baku]]

Attachment: Bug 1554377 - Cleanup nsCookie implementation - network_cookie_thirdparty_nonsecureSessionOnly to StaticPrefs, r?ehsan

Depends on D32614

Comment 6

[Andrea Marchesini [:baku]]

Attachment: Bug 1554377 - Cleanup nsCookie implementation - Removed mIPCOpen, r?ehsan

Depends on D32615

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/009302f63111
Cleanup nsCookie implementation - Get rid of ConstCookie, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/08f5643acafa
Cleanup nsCookie implementation - Get rid of nsCookieAttributes, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/502bf512c66c
Cleanup nsCookie implementation - simpler nsCookie, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/4a90f6a4c101
Cleanup nsCookie implementation - network.cookie.thirdparty.sessionOnly to StaticPrefs, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/6c5a7ea701e2
Cleanup nsCookie implementation - network_cookie_thirdparty_nonsecureSessionOnly to StaticPrefs, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/519ab3e48848
Cleanup nsCookie implementation - Removed mIPCOpen, r=Ehsan

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/009302f63111
https://hg.mozilla.org/mozilla-central/rev/08f5643acafa
https://hg.mozilla.org/mozilla-central/rev/502bf512c66c
https://hg.mozilla.org/mozilla-central/rev/4a90f6a4c101
https://hg.mozilla.org/mozilla-central/rev/6c5a7ea701e2
https://hg.mozilla.org/mozilla-central/rev/519ab3e48848