Closed Bug 1554377 Opened 3 years ago Closed 3 years ago

Cleanup nsCookie implementation

Categories

(Core :: Networking: Cookies, task, P2)

Product:
Core
Component:
Networking: Cookies
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

(Whiteboard: [necko-triaged])

Attachments

(6 files)

Bug 1554377 - Cleanup nsCookie implementation - Get rid of ConstCookie, r?ehsan
47 bytes, text/x-phabricator-request
Details | Review
Bug 1554377 - Cleanup nsCookie implementation - Get rid of nsCookieAttributes, r?ehsan
47 bytes, text/x-phabricator-request
Details | Review
Bug 1554377 - Cleanup nsCookie implementation - simpler nsCookie, r?ehsan
47 bytes, text/x-phabricator-request
Details | Review
Bug 1554377 - Cleanup nsCookie implementation - network.cookie.thirdparty.sessionOnly to StaticPrefs, r?ehsan
47 bytes, text/x-phabricator-request
Details | Review
Bug 1554377 - Cleanup nsCookie implementation - network_cookie_thirdparty_nonsecureSessionOnly to StaticPrefs, r?ehsan
47 bytes, text/x-phabricator-request
Details | Review
Bug 1554377 - Cleanup nsCookie implementation - Removed mIPCOpen, r?ehsan
47 bytes, text/x-phabricator-request
Details | Review

Currently we have basically the same data struct with 4 different implementations:

  1. nsCookie - used for nsICookie and nsICookie2 interfaces
    https://searchfox.org/mozilla-central/rev/4606c7974a68cab416c038acaedcae49eed93822/netwerk/cookie/nsCookie.h

  2. nsCookieAttributes - used for cookie parsing
    https://searchfox.org/mozilla-central/rev/4606c7974a68cab416c038acaedcae49eed93822/netwerk/cookie/nsCookieService.h#203

  3. ConstCookie - used mainly for 1 method only
    https://searchfox.org/mozilla-central/rev/4606c7974a68cab416c038acaedcae49eed93822/netwerk/cookie/nsCookieService.h#92

  4. CookieStruct - used for IPC
    https://searchfox.org/mozilla-central/rev/4606c7974a68cab416c038acaedcae49eed93822/netwerk/ipc/NeckoChannelParams.ipdlh

We should have 1 implementation only. I pick CookieStruct.

Priority: -- → P2
Whiteboard: [necko-triaged]
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/009302f63111
Cleanup nsCookie implementation - Get rid of ConstCookie, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/08f5643acafa
Cleanup nsCookie implementation - Get rid of nsCookieAttributes, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/502bf512c66c
Cleanup nsCookie implementation - simpler nsCookie, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/4a90f6a4c101
Cleanup nsCookie implementation - network.cookie.thirdparty.sessionOnly to StaticPrefs, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/6c5a7ea701e2
Cleanup nsCookie implementation - network_cookie_thirdparty_nonsecureSessionOnly to StaticPrefs, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/519ab3e48848
Cleanup nsCookie implementation - Removed mIPCOpen, r=Ehsan
You need to log in before you can comment on or make changes to this bug.