1554382 - Clear buttom in QFB searchbox squashed

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Since bug 1430165 the clear button in the QFB searchbox is squashed. Bug 1430165 introduced a Photon icon which interferes with our icon.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1554382-QFB-clear-button.patch

I decided to use the toolkit icon to have no issues with changes they are doing in toolkit.

The only change is, that I added some feedback on hovering and clicking which is completely missing on the toolkit button.

Comment 2

[:aceman]

Comment on attachment 9067525 [details] [diff] [review]
1554382-QFB-clear-button.patch

Review of attachment 9067525 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, works for me on Linux. I don't care how the icon looks like, it is still a cross.
On hover it does not look squashed now, it changes darkness of the grey color.
So all is fine, thanks.

Comment 3

[:aceman]

Looks like m-c did this in v68, we may need it on beta too.

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9067525 [details] [diff] [review]
1554382-QFB-clear-button.patch

[Approval Request Comment]
Regression caused by (bug #):  1430165
User impact if declined: squashed icon
Testing completed (on c-c, etc.): about to land on c-c
Risk to taking this patch (and alternatives if risky): we use the m-c icon, so we can then blame them. ;-)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a37b55df5e0b
Use the Photon clear button in the QFB searchbox. r=aceman

Comment 6

[Jorg K (CEST = GMT+2)]

TB 68 beta:
https://hg.mozilla.org/releases/comm-beta/rev/f87f60de9952a2d461877e8cd1ab232a28473ea4

Comment 7

[Jorg K (CEST = GMT+2)]

At least on the last TB 68 beta I've compiled, the image goes small when you click it :-(

Comment 8

[Richard Marti (:Paenglab)]

This is as a feedback for the click. No change to before. Tested the beta from treeherder and it does what it should.

Comment 9

[Jorg K (CEST = GMT+2)]

If you click it, it's mildly squashed: 12px wide, 11 px high :-( - Where else can I see a close button that goes smaller when clicked?

Comment 10

[Richard Marti (:Paenglab)]

I can remove the active state.