Closed Bug 1554506 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 17017 - Corrected and improved absolute_length_units.html

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 17017 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17017
Details from upstream follow.

Gérard Talbot <github@gtalbot.org> wrote:

Corrected and improved absolute_length_units.html

Changes, corrections and improvements done to absolute_length_units.html are

  • added charset
  • removed text assert which collided and contradicted title description
  • corrected link to specification
  • replaced hexadecimal colors with named colors (easier to maintain)
  • changed red for a test neutral color (fuchsia)
  • removed unneeded, unnecessary and irrelevant css zero-reset rule; default values are fine, sufficient
  • tweaked the expected-result sentences
  • replaced tab characters with 2 blank white spaces

The test could be further improved by removing underscore ("_") characters in filename and by adding "-manual" to the base filename.

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/882bacfad7e2
[wpt PR 17017] - Corrected and improved absolute_length_units.html, a=testonly

https://hg.mozilla.org/mozilla-central/rev/882bacfad7e2

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream error] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.