Closed Bug 1554542 Opened 1 year ago Closed 1 year ago

browser.urlbar.doubleClickSelectsAll:true doesn't work with Quantumbar

Categories

(Firefox :: Address Bar, defect, P1)

68 Branch
Unspecified
Linux
defect
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 69
Iteration:
69.2 - May 27 - Jun 9
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox68 + fixed
firefox69 --- fixed

People

(Reporter: yoasif, Assigned: dao)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

As seen on https://www.reddit.com/r/firefox/comments/btds5e/beta_68_cant_select_full_url_with_double_click/

Steps to reproduce:

  1. Set "browser.urlbar.doubleClickSelectsAll:true"
  2. Double click awesomebar

What happens:

The entire URL is not selected.

Expected result:

The entire URL is selected.

Has STR: --- → yes
Regressed by: 1548031
Version: 67 Branch → 68 Branch

:yoasif, if you think that's a regression, then could you try to find a regression range in using for example mozregression?

7:28.29 INFO: No more inbound revisions, bisection finished.
7:28.29 INFO: Last good revision: d1f9cf74a077fe71234115dafdee9c0723b58e93
7:28.29 INFO: First bad revision: a8fcad5870bad1bc7d9b355e2b3348753f7385c7
7:28.29 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d1f9cf74a077fe71234115dafdee9c0723b58e93&tochange=a8fcad5870bad1bc7d9b355e2b3348753f7385c7

Is that pref exposed anywhere in the UI? If not I don't think this warrants tracking.

(In reply to Julien Cristau [:jcristau] from comment #3)

Is that pref exposed anywhere in the UI? If not I don't think this warrants tracking.

It's enabled by default on Linux.

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 69.2 - May 27 - Jun 9
Points: --- → 2
Priority: -- → P2
Priority: P2 → P1
OS: Unspecified → Linux
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cab022901ff7
Fix browser.urlbar.doubleClickSelectsAll handling. r=mak
Flags: in-testsuite+
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/37fb14fc763a
Fix browser.urlbar.doubleClickSelectsAll handling: remove unused variable assignment
Blocks: 1494274
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

Comment on attachment 9067706 [details]
Bug 1554542 - Fix browser.urlbar.doubleClickSelectsAll handling. r=mak

Beta/Release Uplift Approval Request

  • User impact if declined: See comment 0. (browser.urlbar.doubleClickSelectsAll = true is the default on Linux.)
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): trivial fix
  • String changes made/needed: -
Attachment #9067706 - Flags: approval-mozilla-beta?

Comment on attachment 9067706 [details]
Bug 1554542 - Fix browser.urlbar.doubleClickSelectsAll handling. r=mak

quantumbar fix for 68.0b6

Attachment #9067706 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.