1554542 - browser.urlbar.doubleClickSelectsAll:true doesn't work with Quantumbar

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Asif Youssuff]

As seen on https://www.reddit.com/r/firefox/comments/btds5e/beta_68_cant_select_full_url_with_double_click/

Steps to reproduce:

1. Set "browser.urlbar.doubleClickSelectsAll:true"
2. Double click awesomebar

What happens:

The entire URL is not selected.

Expected result:

The entire URL is selected.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:yoasif, if you think that's a regression, then could you try to find a regression range in using for example mozregression?

Comment 2

[Asif Youssuff]

7:28.29 INFO: No more inbound revisions, bisection finished.
7:28.29 INFO: Last good revision: d1f9cf74a077fe71234115dafdee9c0723b58e93
7:28.29 INFO: First bad revision: a8fcad5870bad1bc7d9b355e2b3348753f7385c7
7:28.29 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d1f9cf74a077fe71234115dafdee9c0723b58e93&tochange=a8fcad5870bad1bc7d9b355e2b3348753f7385c7

Comment 3

[Julien Cristau [:jcristau]]

Is that pref exposed anywhere in the UI? If not I don't think this warrants tracking.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Julien Cristau [:jcristau] from comment #3)

Is that pref exposed anywhere in the UI? If not I don't think this warrants tracking.

It's enabled by default on Linux.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1554542 - Fix browser.urlbar.doubleClickSelectsAll handling. r=mak

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cab022901ff7
Fix browser.urlbar.doubleClickSelectsAll handling. r=mak

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37fb14fc763a
Fix browser.urlbar.doubleClickSelectsAll handling: remove unused variable assignment

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/cab022901ff7
https://hg.mozilla.org/mozilla-central/rev/37fb14fc763a

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 9067706 [details]
Bug 1554542 - Fix browser.urlbar.doubleClickSelectsAll handling. r=mak

Beta/Release Uplift Approval Request

• User impact if declined: See comment 0. (browser.urlbar.doubleClickSelectsAll = true is the default on Linux.)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial fix
• String changes made/needed: -

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 9067706 [details]
Bug 1554542 - Fix browser.urlbar.doubleClickSelectsAll handling. r=mak

quantumbar fix for 68.0b6

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/466ee338b43b
https://hg.mozilla.org/releases/mozilla-beta/rev/e5154e181cb3