Add way to submit all unsubmitted comments & actions in a stack
Categories
(Conduit :: Phabricator, enhancement)
Tracking
(Not tracked)
People
(Reporter: mozbugz, Unassigned)
References
Details
Bug 1496109 is about "viewing all comments on a stack of changes in one page" and bug 1536721 "show number of open/total issues on entire stack of revisions". They are kind of related, but I think they were only intended for existing already-submitted issues/comments.
Here I would like to request some way to submit everything pending in a stack.
And optionally show a list of these (similar to bug 1496109), and/or show the number of unsubmitted comments in the stack view (similar to bug 1536721).
The use case is my usual workflow when dealing with a stack:
- As a reviewer, I go through each patch in the stack, adding comments. I don't want to submit comments on one patch before starting the next one, because sometimes comments are already addressed in later patches, so I want to come back and remove/update previous comments. Then when I'm satisfied that I've reviewed everything, I currently need to go through each patch and click "submit", instead I'd like to just click one "Submit all in stack" button.
- As an author, I go through each patch in the stack, marking review comments done and responding to some. But I only want to submit these all at once when I'm about to push updated patches (because it can take some time to make changes needed for each review comment, and perform the proper testing, and I don't want to bother the reviewer beforehand).
|
||
Comment 1•6 years ago
|
||
There is a ton of complexity in implementing a feature like this, even if done upstream (which they will not do). For example, you must consider things like currently being edited textboxes in other windows. Implementing this as an extension would be nearly if not impossible.
You may be able to do something like this through a script hitting the API if it is that much of an inconvenience for you.
Description
•