1554626 - Add surface size to external_vr struct

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Description

[Imanol Fernandez]

In Firefox Reality we need a way to get the WebVR surface size received from Gecko in order to resize the HMD swapchain. This will allow to improve WebVR texture sharpness issues in somepages such as https://www.tourdeforce360.com/grandtheater/vtour.html. They use a 2x size for the canvas from the recommended size provided by the WebVR API

Comment 1

[Imanol Fernandez]

Attachment: Bug 1554626 - Add surface size to external_vr struct.

Add surface size to external_vr struct

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3edfeee54f00
Add surface size to external_vr struct. r=kip,daoshengmu,rbarker

Comment 3

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=3edfeee54f00482d79c5971b466d3c89a20b969e&selectedJob=248809356

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=248809356&repo=autoland&lineNumber=18346

[task 2019-05-28T21:28:49.355Z] 21:28:49 ERROR - /builds/worker/workspace/build/src/gfx/vr/gfxVRExternal.cpp:212:29: error: use of undeclared identifier 'surf'
[task 2019-05-28T21:28:49.355Z] 21:28:49 INFO - aTextureSize->width = surf->GetDevicePixelWidth();
[task 2019-05-28T21:28:49.355Z] 21:28:49 INFO - ^
[task 2019-05-28T21:28:49.355Z] 21:28:49 ERROR - /builds/worker/workspace/build/src/gfx/vr/gfxVRExternal.cpp:213:30: error: use of undeclared identifier 'surf'
[task 2019-05-28T21:28:49.355Z] 21:28:49 INFO - aTextureSize->height = surf->GetDevicePixelHeight();
[task 2019-05-28T21:28:49.355Z] 21:28:49 INFO - ^
[task 2019-05-28T21:28:49.356Z] 21:28:49 INFO - 2 errors generated.
[task 2019-05-28T21:28:49.356Z] 21:28:49 INFO - /builds/worker/workspace/build/src/config/rules.mk:810: recipe for target 'gfxVRExternal.o' failed
[task 2019-05-28T21:28:49.356Z] 21:28:49 ERROR - make[4]: *** [gfxVRExternal.o] Error 1
[task 2019-05-28T21:28:49.356Z] 21:28:49 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/vr'
[task 2019-05-28T21:28:49.356Z] 21:28:49 INFO - make[4]: *** Waiting for unfinished jobs....
[task 2019-05-28T21:28:49.359Z] 21:28:49 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/base'
[task 2019-05-28T21:28:49.361Z] 21:28:49 INFO - dom/base/nsDOMWindowUtils.o
[task 2019-05-28T21:28:49.362Z] 21:28:49 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/base'

Backout: https://hg.mozilla.org/integration/autoland/rev/c6a7bca3f2fa7a10cec63fb04e4736f441c2adf7

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7482504ed63
Add surface size to external_vr struct. r=kip,daoshengmu,rbarker

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c7482504ed63