155468 - Installation of c11n build crash due to incorrect attributes for Viewpoint

Status: VERIFIED FIXED

(CCK Graveyard :: CCK-Wizard, defect)

Description

[Jimmy Uen]

Creating a c11n build with selected Viewpoint component during installation it 
doesn't display as a selectable component when doing custom install. Also it 
crash "Error occur during installation - Viewpoint Media Player: -204 
NO_INSTALL_SCRIPT"

The c11n build config.ini for Viewpoint should be as follow ~
[Component Viewpoint]
Attributes=SELECTED|UNCOMPRESS|LAUNCHAPP

Currently, it is as follow ~
Attributes=SELECTED|INVISIBLE

Comment 1

[Shruti Vasudevan]

Attachment: Patch to include correct attributes for Viewpoint

Patch includes the following changes:
- Updated code to include newly introduced attributes like SUPERSEDE, VISIBLE,
etc.
- Empty attributes are now replaced with 'VISIBLE' attribute in installer,
accordingly updated cecko code.
- Included some code cleaning: Removed the age old unreadable code (multiple
conditions in if else) and replaced it with better/easier code. This may help
all cecko developers to easily fix similar bugs (introduced everytime attribute
changes are made in browser) and also reduces a code cleaning bug in my list
:-)

Comment 2

[Steve Meredith (gone)]

I asked for a few comments, then r=smeredith.

Comment 3

[Shruti Vasudevan]

Attachment: Updated patch with cmments

Comment 4

[Shruti Vasudevan]

Resolving fixed.

Comment 5

[Jimmy Uen]

VErified with CCK 2002-07-16-11-1.0