1554701 - Replace CSSProperties.isValidOnClient() with CSS.supports()

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Razvan Caliman [:rcaliman]]

The CSSProperties front has a method called isValidOnClient() which seems to do client-side validation of CSS (meaning, no trips to the server for a highly accurate CSS validation on the inspected page; see bug 1532947).

This method was introduced by bug 1291866 in Firefox 52.

There are a few places where isValidOnClient() and its helper getValidityChecker() are used which result in tight coupling between components and a lot of drilling down of the method, notably in:

• OutputParser constructor
• SwatchFilterTooltip constructor which passes it down to CSSFilterEditorWidget constructor

Given the current native support for CSS.supports() and the scope of the method, it seems that isValidOnClient can be replaced by CSS.supports() where required. This will cleanup the code a bit and reduce the tight coupling between components and the CSSProperties front.

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1554701 - Replace CssProperties.isValidOnClient() with CSS.supports() r=gl

Given that CssProperties.isValidOnClient() does only a client-side check for support of a CSS declaration, we can leverage the built-in CSS.supports() method and remove some of the inter-dependencies between the CssProperties object from the CssPropertiesFront and its consumers, OutputParser and FilterWidget.

Comment 2

[Razvan Caliman [:rcaliman]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8322e18ae1dc2925eb7b2cc2b148b364f15b63e3

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02f651368fa8
Replace CssProperties.isValidOnClient() with CSS.supports() r=gl

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/02f651368fa8