1554704 - No error is displayed in the First Run modals if an email without a top-level domain is submitted

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: no TLD email should show an error.gif

[Affected versions]:

• Firefox Nightly 69.0a1, Build ID 20190527095441
• Firefox Beta 68.0b4, Build ID 20190523115432
• Firefox Release 67.0.1, Build-ID 20190523020236 (treeherder build)

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have the trailhead.firstrun.branches set to join-privacy in a new profile.

[Steps to reproduce]:

1. Start the browser with the profile from prerequisites.
2. Navigate to about:welcome and focus the email field.
3. Enter a valid email with an @ symbol, but without a TLD (eg. valid@email).
4. Press Enter or click the "Continue" button.

[Expected results]:

• The "Valid email required" error is displayed.

[Actual results]:

• No error is displayed and the user is redirected to the accounts.firefox.com page where the error is displayed.

[Notes]:

• The issue is reproducible on the sync and control modals.
• Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

This happens because accounts.firefox.com has a stricter email verification than the default one in firefox (which allows the technically valid tld-less email address)

Comment 2

[Kate Hudson :k88hudson]

Links to code from FXA side:

https://github.com/mozilla/fxa/blob/master/packages/fxa-auth-server/lib/routes/validators.js#L57-L85
https://github.com/mozilla/fxa/blob/master/packages/fxa-auth-server/lib/routes/validators.js#L135-L167

Comment 3

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Marking this as Verified as this this was Resolved by us no longer using that modal since we have switched to the Simplified Onboarding view.