Closed
Bug 1554727
Opened 5 years ago
Closed 5 years ago
Rule-view empty when using vertical-align in the element rule
Categories
(DevTools :: Inspector: Rules, defect, P1)
DevTools
Inspector: Rules
Tracking
(firefox69 fixed)
VERIFIED
FIXED
Firefox 69
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: pbro, Assigned: pbro)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Steps:
- open this URL
data:text/html,<div style="vertical-align:sub;"> - open the inspector
- select the div in the inspector
==> The rule-view is empty.
This is a regression from bug 1551812 where I added some code that checks the selector of a node, but didn't account for cases when there are no selectors (i.e. an inline style).
Here's the faulty code: https://searchfox.org/mozilla-central/rev/aba472751e24763d0c18bae8408e9d7106e9acea/devtools/server/actors/utils/inactive-property-helper.js#142-143
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Priority: -- → P1
|
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by pbrosset@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/87568c2f564b Check if selectorText exists before testing its content; r=miker
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
|
||
Comment 4•5 years ago
|
||
Verified with Firefox 68.0 (20190705220548), 69.0a1 (2019-07-07).
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•