Closed Bug 1554787 Opened 7 years ago Closed 2 years ago

Add blame functionality to mobile sources

Categories

(Webtools :: Searchfox, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: davidb, Unassigned)

Details

No description provided.

Just to fill this in: https://searchfox.org/mozilla-central has a nice blame bar on the left, but https://searchfox.org/mozilla-mobile does not have such a bar. kats suggests that this is just not yet implemented for submodule agglomerations like mozilla-mobile.

Quoting myself from https://bugzilla.mozilla.org/show_bug.cgi?id=1523349#c6 with some interesting new context below which I think suggests this use-case may be self-mooting / should be addressed outside of searchfox's custom handling other than indexing the new mono-repo.

In terms of this general use case https://github.com/mozilla-mobile/android-components/issues/12751 announced the creation of a mono-repo-ish thing that will live at https://github.com/mozilla-mobile/firefox-android. It seems like this won't completely obsolete the use-case for searchfox's synthetic mozilla-mobile mono-repo, but arguably the right next step for that is likely for the https://github.com/mozilla-mobile org to publish its own mono-repo with automation to keep it updated, ideally using git subtrees (probably?) and searchfox can then index that; this blog post I randomly found via search I think generally captures my thoughts and steps for how that might be done. I believe this would immediately address the lack of annotate/blame support for the existing synthetic mozilla-mobile.

Going to declare this WFM since the mobile repositories of note are being folded into mozilla-central. There's also a WONTFIX component to this when it comes to blame support for submodules, but that said, I think it would be feasible to support the mozilla-mobile idiom where searchfox can support a composite repo type where we have N sibling repositories that are all their own completely separate trees but exposed from within a single search/semantic namespace. In particular, this would be useful for web standards.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.