1554841 - Cookies: wrong heading for hostOnly, isSecure and isHttpOnly columns

Status: VERIFIED FIXED

(DevTools :: Storage Inspector, defect, P2)

Description

[Zhiming Wang]

Attachment: Screen Shot 2019-05-28 at 12.17.49 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

(Firefox Developer Edition v68.0b4 on macOS 10.14.5.)

• Open Web Developer -> Storage Inspector -> Cookies.

Actual results:

The heading for the isHttpOnly column is table.headers.cookies.isHttpOnly (see screenshot). Since the column is usually narrow, the important part is usually hidden in ellipsis. I suppose the table.headers.cookies. part isn't meant to be displayed.

Expected results:

The heading should just be isHttpOnly, or even just httpOnly.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I can confirm that the following l10n strings are missing:

• table.headers.cookies.hostOnly
• table.headers.cookies.isSecure
• table.headers.cookies.isHttpOnly

These strings were erroneously removed back in Firefox 51 by https://hg.mozilla.org/mozilla-central/rev/ca23fe6f13f4.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Whilst we are fixing this we should make the headers match the values used when creating cookies.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1554841 - l10n corrections in storage inspector cookie table headers r?pbro!

Changes

Set 1 - Match cookie creation strings, remove "on" and capitalize.

• Expires on => Expires
• Last accessed on => Last accessed
• Created on => Created
• sameSite => SameSite

Set 2 - Re-add missing strings

• table.headers.cookies.isHttpOnly=HttpOnly
• table.headers.cookies.isSecure=Secure
• table.headers.cookies.hostOnly=HostOnly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ab582d1ab37
l10n corrections in storage inspector cookie table headers r=pbro

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4ab582d1ab37

Comment 6

[Cristian Fogel [:cfogel]]

Confirmed with 68.0b14 Windows 10.
Fix verified with 69.0b8 on Windows 10, macoS 10.14. Ubuntu 16.04.