Cookies: wrong heading for hostOnly, isSecure and isHttpOnly columns

RESOLVED FIXED in Firefox 69

Status

defect
P2
normal
RESOLVED FIXED
2 months ago
Last month

People

(Reporter: i, Assigned: miker)

Tracking

68 Branch
Firefox 69

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(2 attachments)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

(Firefox Developer Edition v68.0b4 on macOS 10.14.5.)

  • Open Web Developer -> Storage Inspector -> Cookies.

Actual results:

The heading for the isHttpOnly column is table.headers.cookies.isHttpOnly (see screenshot). Since the column is usually narrow, the important part is usually hidden in ellipsis. I suppose the table.headers.cookies. part isn't meant to be displayed.

Expected results:

The heading should just be isHttpOnly, or even just httpOnly.

Component: Untriaged → Storage Inspector
Product: Firefox → DevTools

I can confirm that the following l10n strings are missing:

  • table.headers.cookies.hostOnly
  • table.headers.cookies.isSecure
  • table.headers.cookies.isHttpOnly

These strings were erroneously removed back in Firefox 51 by https://hg.mozilla.org/mozilla-central/rev/ca23fe6f13f4.

Assignee: nobody → mratcliffe
Status: UNCONFIRMED → ASSIGNED
Has Regression Range: --- → yes
Has STR: --- → yes
Ever confirmed: true
OS: Unspecified → All
Priority: -- → P2
Hardware: Unspecified → All
Summary: Storage inspector -> Cookies: wrong heading for isHttpOnly column → Cookies: wrong heading for hostOnly, isSecure and isHttpOnly columns

Whilst we are fixing this we should make the headers match the values used when creating cookies.

Changes

Set 1 - Match cookie creation strings, remove "on" and capitalize.

  • Expires on => Expires
  • Last accessed on => Last accessed
  • Created on => Created
  • sameSite => SameSite

Set 2 - Re-add missing strings

  • table.headers.cookies.isHttpOnly=HttpOnly
  • table.headers.cookies.isSecure=Secure
  • table.headers.cookies.hostOnly=HostOnly
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ab582d1ab37
l10n corrections in storage inspector cookie table headers r=pbro
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.