Build fails with recent Linux kernel.
Categories
(Core :: Audio/Video, defect)
Tracking
()
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-release+
RyanVM
:
approval-mozilla-esr68+
|
Details | Review |
/home/emilio/src/moz/gecko/media/webrtc/trunk/webrtc/rtc_base/physicalsocketserver.cc:67:27: error: use of undeclared identifier 'SIOCGSTAMP'
10:38.18 int ret = ioctl(socket, SIOCGSTAMP, &tv_ioctl);
10:38.18
See:
- https://webrtc-review.googlesource.com/c/src/+/138270
- https://bugs.chromium.org/p/webrtc/issues/detail?id=10677
For the analysis.
Assignee | ||
Comment 1•5 years ago
|
||
Recent kernel commit1 moved a bit the define for this constant. This revealed
a missing include in WebRTC.
I filed this upstream in:
And sent a patch in:
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/49be991ad4d9 Fix WebRTC build failure with newer linux kernel. r=dminor
Comment 3•5 years ago
|
||
bugherder |
Assignee | ||
Comment 5•5 years ago
|
||
Comment on attachment 9067982 [details]
Bug 1554949 - Fix WebRTC build failure with newer linux kernel. r=dminor
Beta/Release Uplift Approval Request
- User impact if declined: No user impact, but people may be unable to build 68 / ESR on newer Linux kernels.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial build fix that allows to build FF68 on newer Linux kernels.
- String changes made/needed: none
Assignee | ||
Comment 6•5 years ago
|
||
Comment on attachment 9067982 [details]
Bug 1554949 - Fix WebRTC build failure with newer linux kernel. r=dminor
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: See above
- User impact if declined: See above
- Fix Landed on Version: 69
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial build fix on Linux only.
- String or UUID changes made by this patch: none
Assignee | ||
Comment 7•5 years ago
|
||
Comment on attachment 9067982 [details]
Bug 1554949 - Fix WebRTC build failure with newer linux kernel. r=dminor
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: See above
- User impact if declined: See above
- Fix Landed on Version: 69
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial build fix on Linux only.
- String or UUID changes made by this patch: none
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: See above
- User impact if declined: See above
- Fix Landed on Version: 69
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial build fix on Linux only.
- String or UUID changes made by this patch: none
Assignee | ||
Comment 8•5 years ago
|
||
Well, BMO got confused here...
Comment 9•5 years ago
|
||
Comment on attachment 9067982 [details]
Bug 1554949 - Fix WebRTC build failure with newer linux kernel. r=dminor
Fixes a build issue on newer Linux kernels. Approved for 68.1esr. Since it doesn't affect the builds we ship, I'll approve this for mozilla-release as well in the event that we ship another dot release from there, but I won't guarantee that'll happen either.
Comment 10•5 years ago
|
||
uplift |
Comment 11•5 years ago
|
||
bugherder uplift |
Comment 12•5 years ago
|
||
uplift |
Also pushed to FIREFOX_ESR_68_0_X_RELBRANCH for consistency:
https://hg.mozilla.org/releases/mozilla-esr68/rev/03fe96d5969ac6885ca539bf7759780ed75a1375
Description
•