Closed Bug 1554951 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 17043 - wake-lock: Fix invalid types test in wakelock-type.https.any.js

Categories

(Testing :: web-platform-tests, defect, P4)

Product:
Testing
Component:
web-platform-tests
Type:
defect

Tracking

(firefox69 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 17043 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17043
Details from upstream follow.

Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> wrote:

wake-lock: Fix invalid types test in wakelock-type.https.any.js

During #17019's review process, async was dropped from a promise_test(),
and we ended up not returning a Promise there at all.

Fix the test by wrapping the invalidTypes.map() call in Promise.all().

PR 17043 applied with additional changes from upstream: 7cb8a811bbba84c4da802dbd9cce3247104dca77, 2cbf0de743f3545c7751b6d5304ffb52d744db32
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e0eab1eb577
[wpt PR 17043] - wake-lock: Fix invalid types test in wakelock-type.https.any.js, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2e0eab1eb577

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.