Closed Bug 1554966 Opened 2 years ago Closed 2 years ago

Investigate running raptor-youtube-playback tests always muted on desktop

Categories

(Testing :: Raptor, defect, P2)

defect

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: whimboo, Assigned: marauder)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently we run the tests muted on Android but not on desktop. It should be investigated if we can run those tests muted everywhere. Therefore the tests have to be run in CI with the Gecko profiler being enabled.

As mentioned by Paul Adenot it shouldn't make a difference. If numbers validate that then run the tests muted across all platforms.

Priority: -- → P2

:marauder could you trigger some try jobs to compare running these tests on desktop muted vs audible?

Assignee: nobody → marian.raiciof
Status: NEW → ASSIGNED
Flags: needinfo?(marian.raiciof)

Paul: are you able to compare the profiles to confirm if there is any difference running muted?
Marian: could you also trigger try runs without the gecko profiler with a few retriggers so we can compare results via the compare view?

Flags: needinfo?(padenot)
Flags: needinfo?(marian.raiciof)
Flags: needinfo?(marian.raiciof)

The comparison view is at https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=562e65a1114452ad34dc0a6b0c5943c34f284cbd&newProject=try&newRevision=a209d7cbe08314f7a4482a4ea1ac54418db59575&framework=10

It looks like muting might have a positive impact on the performance for linux, and a slightly negative impact on other platforms. In all cases the confidence is low, so I think we can proceed with running the tests muted so long as Paul has no concerns.

This is fine, as long as you compare the same things. Why do we want to mute the videos again?

Flags: needinfo?(padenot)

(In reply to Paul Adenot (:padenot) from comment #6)

This is fine, as long as you compare the same things. Why do we want to mute the videos again?

Because with GeckoView there is no way yet to get around the problem that autoplay is blocked. As such using muted playback everywhere the numbers across platforms should be closer.

Based on the conclusion from the bug mentioned above, we will run youtube playback always muted on desktop.

Pushed by mraiciof@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d87604ba6a87
Investigate running raptor-youtube-playback tests always muted on desktop r=perftest-reviewers,sparky
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.