1555044 - Update Onboarding's Sync screen text

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: image.png

The Sync screen should be updated as per the attached image with the following text:
Text: "Sign in to your account to get the most out of &brandShortName;"
Signin button text: "Sign in to &brandShortName;"

We just need this new strings landed asap to offer localizers as much time as possible for translating them.
They will be separate, new strings because we'll fallback to the older, previously translated ones in the case these will not yet be translated at runtime.
If this strings are to be added before the code that uses them we would to suppress the UnusedResources lint check.

Comment 1

[Brad Arant]

Attachment: Bug 1555044 - Updated onboarding strings to provide request.;r?VladBaicu

Comment 2

[Brad Arant]

Provided new strings for requested views prefixed by 'updated....' and left the old string in case reversion is required per the request.

Comment 3

[Diana Iacos]

Attachment: Bug 1555044 - Update Onboarding's Sync screen text; r?petru

Because the news strings are unused we need to add them in lint.xml as UnusedResources.
The suppress will be removed it in a future patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ab725c2a885
Update Onboarding's Sync screen text; r=petru

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2ab725c2a885

Comment 6

[Chris Peterson [:cpeterson]]

Diana, can you please request uplift to Fennec 68 Beta? We'll need the new strings for Fennec 68. I'll file a new bug to use your new strings in Fennec's onboarding code. :)

Looks like updatednewfirstrun_sync_subtext ("Sign in to your account to get the most out of &brandShortName;") has been translated to 38 locales so far:
https://pontoon.mozilla.org/en-CA/firefox-for-android/mobile/android/base/android_strings.dtd/?string=199601

And updatednewfirstrun_signin_button ("Sign in to &brandShortName;") has been translated to 41 locales:
https://pontoon.mozilla.org/en-CA/firefox-for-android/mobile/android/base/android_strings.dtd/?string=199599

Comment 7

[Diana Iacos]

Comment on attachment 9068317 [details]
Bug 1555044 - Update Onboarding's Sync screen text; r?petru

Beta/Release Uplift Approval Request

• User impact if declined: Onboarding's Sync Screen will use outdated text.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The changes are not risky because we added only 2 strings.
• String changes made/needed: The strings that were added : "updatednewfirstrun_sync_subtext" and "updatednewfirstrun_signin_button"

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9068317 [details]
Bug 1555044 - Update Onboarding's Sync screen text; r?petru

fennec string updates, approved for 68.0b9

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a08ebd3c9870

Comment 10

[Stefan Deiac]

Hello, I can confirm that the issue is fixed on the latest Nightly 69.0a1 (2019-07-03) using Google Pixel (Android Q) but it is not fixed on the latest Beta from the Playstore 68.0b14.

Comment 11

[Petru-Mugurel Lingurar [:petru]]

(In reply to Stefan Deiac from comment #10)

Hello, I can confirm that the issue is fixed on the latest Nightly 69.0a1 (2019-07-03) using Google Pixel (Android Q) but it is not fixed on the latest Beta from the Playstore 68.0b14.

This ticket only landed the strings to give more time to the localizers to translate.
The work for using them was done in bug 1557635 which indeed is atm only found in m-c, not in beta 68.

Comment 12

[Stefan Deiac]

Verified as fixed on Nightly 68.1a1 (2019-07-17) and Beta 68.1b2 using Motorola Moto G6 (Android 8) and Google Pixel (Android Q).

Comment 13

[Chris Peterson [:cpeterson]]

Changing status-firefox68 flag to status-firefox-esr68 because Fennec Nightly (68.1a1) and Beta (68.1b2) are builds from the ESR 68 branch.