Closed Bug 1555046 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 17047 - Switch to random OS port retrieval for webdriver server

Categories

(Testing :: web-platform-tests, defect, P4)

defect

Tracking

(firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync upstream error])

Sync web-platform-tests PR 17047 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17047
Details from upstream follow.

George Roman <george.roman.99@gmail.com> wrote:

Switch to random OS port retrieval for webdriver server

While working on enabling wdspec tests in Servo, I noticed that although _used_ports is protected by a lock, when running the tests in parallel, each process had the same connection port. Here I provided a full description. Basically, _used_ports is not shared between the processes (each process has a different copy of it) so the changes one process makes to it are not reflected in the other processes. Thus, we get multiple processes running WebDriver on the same port. The easiest way to solve this is to switch to random OS port retrieval by binding to port 0.

PR 17047 applied with additional changes from upstream: 70a130f553c06d0146f90d2d5fbad2aac6685146, 9f751d5c82d293b94525f52d6d211916285316e0
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/3d43d5925998 [wpt PR 17047] - Switch to random OS port retrieval for webdriver server, a=testonly
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream error] → [wptsync upstream error]
You need to log in before you can comment on or make changes to this bug.