Abstract creation and toggling of pseudo-class locks
Categories
(DevTools :: Inspector, task, P2)
Tracking
(firefox69 fixed)
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: rcaliman, Assigned: rcaliman)
References
Details
Attachments
(2 files)
Easing some of the pain experienced when adding a new pseudo-class lock, the patches for this bug concentrate instrumented pseudo-class lock toggles (i.e. the ones we support toggling in the Rules view) and abstract away their creation, event handling and testing.
Fixes Bug 1536676 as a side-effect.
Assignee | ||
Comment 1•5 years ago
|
||
-
Removes the hardcoded references from
index.xhtml
andrules.js
and uses a centralized list of pseudo-classes to generate the checkboxes for the supported pseudo-class locks at runtime. -
Streamlines the handling for pseudo-class locks state. Fixes Bug 1536676 as a side-effect.
-
Updates tests.
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D32867
Reference the shared list of pseudo-elements throughout the codebase:
- markup view context menu + test
- Rule editor
- box model highlighter
- node actor
- new Rules view
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6c342fe3a57b (Part 1) Generalize creation and handling of pseudo-class toggles in the Rules view. r=gl https://hg.mozilla.org/integration/autoland/rev/7ba95be07ebf (Part 2) Centralize the list of supported pseudo-classes. r=gl
Comment 5•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6c342fe3a57b
https://hg.mozilla.org/mozilla-central/rev/7ba95be07ebf
Description
•