1555064 - Abstract creation and toggling of pseudo-class locks

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P2)

Description

[Razvan Caliman [:rcaliman]]

Easing some of the pain experienced when adding a new pseudo-class lock, the patches for this bug concentrate instrumented pseudo-class lock toggles (i.e. the ones we support toggling in the Rules view) and abstract away their creation, event handling and testing.

Fixes Bug 1536676 as a side-effect.

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1555064 - (Part 1) Generalize creation and handling of pseudo-class toggles in the Rules view. r=gl

• Removes the hardcoded references from index.xhtml and rules.js and uses a centralized list of pseudo-classes to generate the checkboxes for the supported pseudo-class locks at runtime.

• Streamlines the handling for pseudo-class locks state. Fixes Bug 1536676 as a side-effect.

• Updates tests.

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1555064 - (Part 2) Centralize the list of supported pseudo-classes. r=gl

Depends on D32867

Reference the shared list of pseudo-elements throughout the codebase:

• markup view context menu + test
• Rule editor
• box model highlighter
• node actor
• new Rules view

Comment 3

[Razvan Caliman [:rcaliman]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=29cf817eb0f1487a28d7d8999422409cc58c74f3

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c342fe3a57b
(Part 1) Generalize creation and handling of pseudo-class toggles in the Rules view. r=gl
https://hg.mozilla.org/integration/autoland/rev/7ba95be07ebf
(Part 2) Centralize the list of supported pseudo-classes. r=gl

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6c342fe3a57b
https://hg.mozilla.org/mozilla-central/rev/7ba95be07ebf