1555066 - Uncaught exceptions in OnProcessCrashed

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Jason Orendorff [:jorendorff]]

Seen here, for example:

09:29:53 INFO - JavaScript error: resource://reftest/reftest.jsm, line 1575: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIPropertyBag2.getPropertyAsAString]
09:29:53 INFO - !!! error running onStopped callback: TypeError: callback is not a function
09:29:53 INFO - JavaScript error: resource://reftest/reftest.jsm, line 1575: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIPropertyBag2.getPropertyAsAString]
09:29:53 INFO - JavaScript error: resource://reftest/reftest.jsm, line 1575: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIPropertyBag2.getPropertyAsAString]

I think the code has had this bug since it was added 8 years ago. Trying to get a property that isn't there is an error.

I guess the fix is to use .get() instead of .getPropertyAsAString().

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1555066 - Fix uncaught exceptions in jsreftest test harness when a content process crashes. r?heycam

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/257a4253848a
Fix uncaught exceptions in jsreftest test harness when a content process crashes. r=heycam

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/257a4253848a