155510 - Double click on column splitter to fit column size

Status: RESOLVED WONTFIX

(Core :: XUL, enhancement)

Description

[Kyle Yuan]

See: 
http://bugzilla.mozilla.org/show_bug.cgi?id=136174#c3

Comment 1

[Kyle Yuan]

Attachment: implemented autosizing function

This patch also fixed some other minor bugs:
1) nsTreeBodyFrame::CalcMaxRowWidth(), row width includes hidden columns;
2) nsTreeBodyFrame::GetCellWidth(), sometimes can't get cell's image size;
3) nsTreeBodyFrame::GetCoordsForCellItem() and GetCellWidth(), forgets to count
image margin
4) nsTreeBodyFrame::GetCoordsForCellItem(), redundant loop after column
matched;

I reserved an interface - fitAllColumns - for bug 136174

Comment 2

[Kyle Yuan]

Jan, could you r= this fix?

Comment 3

[Jan Varga [:janv]]

kyle, why are you adding code to nsSplitterFrame ?
Shouldn't be doubleclick handled in tree.xml ?

Comment 4

[Kyle Yuan]

Jan, this double click action is right on splitter, not on tree column header,
so we must handle it in splitter code. see
http://bugzilla.mozilla.org/show_bug.cgi?id=136174#c3

Comment 5

[Alex Bishop]

*** Bug 157962 has been marked as a duplicate of this bug. ***

Comment 6

[Wesha]

What about making Ctrl-Gray+ resize all columns to "best fit" at once? (It works
in some of Windows grid controls)

Comment 7

[:deanis74]

Wesha: that's handled in either bug 136174 or bug 135749, i've lost track.

Comment 8

[:deanis74]

Adding review keyword.

Comment 9

[Jan Varga [:janv]]

*** Bug 27346 has been marked as a duplicate of this bug. ***

Comment 10

[Prognathous]

(In reply to comment #4)
> Jan, this double click action is right on splitter, not on tree column header,
> so we must handle it in splitter code. see
> http://bugzilla.mozilla.org/show_bug.cgi?id=136174#c3

Jan, can you please comment on this? Is a new approach needed? Should the patch
be updated?

Prog.

Comment 11

[Kyle Yuan]

Comment on attachment 90060 [details] [diff] [review]
implemented autosizing function

My patch is 2 years old. I don't think it's still suitable for current code
base.

Comment 13

[Dave]

Ok, apparently this bug also manifests itself in Thunderbird 3.0.3... and there have been 3 issues marked as duplicate of this bug.

Are there any plans to get this nearly 8-year-*OLD* bug looked at and perhaps fixed?

I don't think this is really an "enhancement" since I believe it is standard (and expected) behavior for columns to auto-resize to fit-to-content when double-clicking the right splitter/handle.

Comment 14

[Jan Varga [:janv]]

I don't think anyone is going to work on this given the plan to remove the XUL "tree" widget (bug 1446335).