1555117 - Starting Firefox with -reset-profile when there is no currently selected profile will do nothing

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Dave Townsend [:mossop]]

The command line argument -reset-profile tells Firefox to refresh its profile on launch. The installer will pass this argument in some cases.

Bug 1518587 made it so if something is telling us to refresh the profile (env value or command line argument) but there is no profile selected (before we attempt to create a new profile) then we consider it an error state and exit.

This break the installer launching Firefox in some cases.

Instead if no profile is found we should just go ahead and create a new one and not refresh it.

Comment 2

[Dave Townsend [:mossop]]

Attachment: Bug 1555117: Ignore attempts to reset the profile when a new profile had to be created for the install. r=froydnj

Since bug 1518587 when a command line argument or environment variable requests
a profile refresh but no existing profile is selected we would just exit
thinking that there is some problem here. But it turns out that the installer
sometimes passes this argument when it doesn't know that the new install will
not use the existing profiles.

So instead we just ignore attempts to refresh when we create a new profile. To
do this we just have to remove the checks that bail out and continue to create
the new profile, nsAppRunner will see that a new profile has been created and
cancel the attempted refresh anyway:
https://searchfox.org/mozilla-central/rev/ddb81c7a43ffada1f6cb4200c4f625e50e44dcf3/toolkit/xre/nsAppRunner.cpp#2021

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57fd8dc8fcdd
Ignore attempts to reset the profile when a new profile had to be created for the install. r=froydnj

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/57fd8dc8fcdd

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 9068167 [details]
Bug 1555117: Ignore attempts to reset the profile when a new profile had to be created for the install. r=froydnj

Beta/Release Uplift Approval Request

• User impact if declined: In certain cases requesting a profile refresh from the installer will make firefox fail to launch when the installer finishes.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This just removes a few checks that bail out of startup.
• String changes made/needed: None

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

Bug 1556173 makes me suspect tests will go red if we uplift this to beta as-is.

Comment 7

[paul deauna]

Cheers

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

FYI, I'd like it to be verified on beta before considering an uplift to release.

Comment 9

[Dave Townsend [:mossop]]

(In reply to Julien Cristau [:jcristau] from comment #6)

Bug 1556173 makes me suspect tests will go red if we uplift this to beta as-is.

I've just queued that up for landing.

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9068167 [details]
Bug 1555117: Ignore attempts to reset the profile when a new profile had to be created for the install. r=froydnj

fix an issue with profile reset, approved for 68.0b10

Comment 11

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f7ba85dff0ee

Comment 12

[Cristian Craciun]

Build ID 20190613215335
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Verified as fixed on the latest Nightly build on Windows 10.

Comment 13

[Cristian Craciun]

Build ID 20190613141208
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Verified as fixed on the latest Beta build (v68b10) on Windows 10.

Comment 14

[Julien Cristau [:jcristau] (back April 22)]

We're not going to ship another 67 dot release.