Closed Bug 1555171 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 17054 - [css-ui] Correct property name

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 17054 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17054
Details from upstream follow.

Mike Pennisi <mike@mikepennisi.com> wrote:

[css-ui] Correct property name

The test for the appearance property mistakenly referred to the vendor
prefixed version, -webkit-appearance. In addition to contradicting the
test name and metadata, this caused the test intended for
-webkit-appearance to reference the non-existent property
-webkit--webkit-appearance.

Correct both tests, using the suite's build process to generate the
-webkit-appearance test from the corrected version of the appearance
test.

Recent research has demonstrated that the menulist-button value is necessary for web compatibility.

This seems to be the only instance of this particular mistake:

 $ git rev-parse HEAD
 48af14aaebdbcaf90bc21d07965f7c16661f8d90
 $ git grep -E 'moz-+moz'
 $ git grep -E 'webkit-+webkit'
 css/css-ui/webkit-appearance-menulist-button-002.html: #container > #drop-down-select { -webkit--webkit-appearance: none; -webkit--webkit-appearance: menulist-button; }
 $

PR 17054 applied with additional changes from upstream: 31e7edc073c29fec0e708a2e883c774b55452421
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/82dcaaad1470
[wpt PR 17054] - [css-ui] Correct property name, a=testonly

https://hg.mozilla.org/mozilla-central/rev/82dcaaad1470

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.