Closed Bug 1555219 Opened 5 years ago Closed 5 years ago

Stop using <resizer>

Categories

(Thunderbird :: General, enhancement)

Product:
Thunderbird
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(thunderbird68 fixed, thunderbird69 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 69.0
Tracking Flags:
Tracking Status
thunderbird68 --- fixed
thunderbird69 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file, 1 obsolete file)

1555219-resizer-2.diff
11.61 KB, patch
Paenglab
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review

I think it's time we got rid of <resizer> (the triangle of dots or stripes in the bottom corner of a window).

  • Our use of it is inconsistent, it's only on some of our dialogue windows. In one case it even appears in the wrong corner due to an empty status bar.
  • It provides very little benefit – only a slightly larger hit target for resizing that corner of the window.
  • It looks wrong and is buggy on Linux. I think there's a small bug on Windows but that may just be my VM being silly.
  • Most other applications including Firefox no longer use them.

Here's the 12 instances we have: https://searchfox.org/comm-central/search?q=%3Cresizer

Attached patch 1555219-resizer-1.diff (obsolete) — — Splinter Review
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9068581 - Flags: review?(richard.marti)
Comment on attachment 9068581 [details] [diff] [review]
1555219-resizer-1.diff

The patch looks good but there is some CSS to remove too: https://searchfox.org/comm-central/search?q=resizer&case=false&regexp=false&path=.css
Attachment #9068581 - Flags: review?(richard.marti)

Yeah, I realised that later but haven't been back here yet.

Let's try that again.

Attachment #9068581 - Attachment is obsolete: true
Attachment #9068650 - Flags: review?(richard.marti)
Comment on attachment 9068650 [details] [diff] [review]
1555219-resizer-2.diff

Thanks.
Attachment #9068650 - Flags: review?(richard.marti) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/78f7fd722424
Stop using <resizer>. r=Paenglab

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

Uplift?

Target Milestone: --- → Thunderbird 69.0
Comment on attachment 9068650 [details] [diff] [review]
1555219-resizer-2.diff

Sure, why not.
Attachment #9068650 - Flags: approval-comm-beta?
Comment on attachment 9068650 [details] [diff] [review]
1555219-resizer-2.diff

Hmm, I really liked the resizer dots. Were they really so bad? :-(
Attachment #9068650 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: