1555259 - [FTL] Copying from Machinery to Source editor results in a broken string

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P3)

Description

[Francesco Lodolo [:flod]]

If you have a simple FTL string, and click on one of the machinery items, you'll end up with a broken string (because the ID = part is lost in the process).

As bug 1555239, this might end up being a WONTFIX, if we decide that it's going to be fixed by having the rich UI.

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #0)

As bug 1555239, this might end up being a WONTFIX, if we decide that it's going to be fixed by having the rich UI.

Actually, I realized this shouldn't be true. This would be a regression from the current behavior when in FTL advanced mode, we should just account for the ID when copying from MACHINERY.

Comment 2

[Matjaz Horvat [:mathjazz]]

Good call - we should make sure copying from Machinery results in a valid string by simply prepending "key = " to the string.

The same thing happens in Source editor in Translate.Current, so I'm removing this from the list of Translate.Next bugs.

Comment 3

[Andreja]

Hello. I'm an Outreachy applicant, is this bug still available?

Comment 4

[Matjaz Horvat [:mathjazz]]

Andreja, the bug is now assigned to you! Please let me know if you have any questions, either here or in #pontoon on IRC.

You can start by installing Pontoon locally using Docker.

Once you have a working local environment, please make sure to read our contribution docs. It contains information on how to style code, how to run tests, how to name your commits, etc. All the things you need to know if you want your work to be merged into Pontoon!

Comment 5

[Andreja]

Thank you!

Comment 6

[Andreja]

Hello. I couldn't install Docker Desktop because I have Windows 10 Home (instead of Pro or Enterprise), even with Hyper-V activated. Is it ok if I install Docker Toolbox which includes Virtual Box?

Comment 7

[Matjaz Horvat [:mathjazz]]

Andreja, sadly I don't know for sure, but looking at https://docs.docker.com/toolbox/toolbox_install_windows/ and https://forums.docker.com/t/installing-docker-on-windows-10-home/11722/2, I would assume the answer is "Yes".

Comment 8

[Andreja]

Great, thanks!

Comment 9

[Andreja]

Hello. I installed Docker Toolbox on my Windows 10 home successfully and did all other steps (https://mozilla-pontoon.readthedocs.io/en/latest/dev/setup.html) until I got this error after running Make build:

Step 6/28 : COPY docker/set_up_ubuntu.sh /tmp/set_up_ubuntu.sh
 ---> Using cache
 ---> 198fc31fd11c
Step 7/28 : RUN /tmp/set_up_ubuntu.sh
 ---> Running in 0e903cdc52c4
/bin/sh: 1: /tmp/set_up_ubuntu.sh: not found
ERROR: Service 'webapp' failed to build: The command '/bin/sh -c /tmp/set_up_ubuntu.sh' returned a non-zero code: 127
make: *** [build] Error 1

I googled it but didn't find a solution.
Thanks!

Comment 10

[Matjaz Horvat [:mathjazz]]

Andreja, sorry for responding so late - seems like the notification email fell through the cracks. :/ I haven't seen this error before and I don't know out of my head what's going wrong. I wonder if it's related to Docker Toolbox. Let's sync on IRC if you're still experiencing this issue.

--

We're getting lots of requests by Outreachy participants, so we often run out of Mentored bugs. We've decided to unassign all Mentored bugs until the assignee sets up a development environment.
​
Please send us a screenshot of your working development environment via #pontoon on Mozilla IRC and we'll assign you a Mentored bug afterwards.
​
Thanks for understanding!

Comment 11

[Andreja]

No problem. Yes, good that you unassigned it, I felt guilty about having it assigned to me :). I started working on another project, I think I am not yet qualified enough to work on the bugs. Thanks.

Comment 12

[Raj Sandhu (:rsandhu)]

Hi all, I'm new here and an Outreachy participant. Judging from my User Activity Report, it looks like I've been assigned this bug. Is this correct?

Comment 13

[Raj Sandhu (:rsandhu)]

I'm currently working through the Pontoon tutorial to understand the tool better from a user perspective, to make some progress on understanding the bugs and how I might be able to fix them.

Comment 14

[Anastasia]

Can I take this one?

Comment 15

[Matjaz Horvat [:mathjazz]]

Anastasia, I've assigned you https://bugzilla.mozilla.org/show_bug.cgi?id=1564841, which is a little more challenging. :)

Let's sync via email/IRC if you want to work on something else instead or if you need anything else.

Comment 16

[Karskaya]

@mathjazz, can I try with this one?

Comment 17

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1454

Comment 18

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1459

Comment 19

[[DEACTIVATED] Adrian Gaudebert]

adngdb merged PR #1459: "Bug 1555259: Copying from Machinery to Source editor results in a broken string" in 82190d5.