1555293 - 0.13 - 0.16% installer size (osx-shippable) regression on push 9473fc5214f68bfded83c5f8dd8d582051037008

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P1)

Description

[Ionuț Goldan [:igoldan]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5d620aaff95a8ca5a6be0e269ccea4b6d72b1c8f&tochange=9473fc5214f68bfded83c5f8dd8d582051037008f

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

+100KBytes installer size osx-shippable opt gcp nightly 78,339,813.38 -> 78,463,560.75
+100KBytes installer size osx-shippable opt nightly 78,371,574.75 -> 78,474,716.58

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=21058

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Comment 1

[Ionuț Goldan [:igoldan]]

Other desktop platforms were affected as well, but to a lesser degree.

Comment 2

[Jason Laster [:jlast]]

Hi, the regression came from this patch where I added whatwg-url as a dependency in vendors.js. Currently whatwg-url is also vendored for the source-map worker. I would like to have one copy of it that is shared between both locations.

What do you think is a good priority for this task?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Having a single shared copy sounds like a good plan.

Comment 4

[Jason Laster [:jlast]]

Attachment: Bug 1555293 - Fix 0.13 - 0.16% installer size. r=davidwalsh

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2afcbee986e1
Fix 0.13 - 0.16% installer size. r=davidwalsh

Comment 6

[Jason Laster [:jlast]]

Attachment: Bug 1555293 - Fix 0.13 - 0.16% installer size. r=davidwalsh

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/2afcbee986e1