Closed Bug 1555300 Opened 1 year ago Closed 1 year ago

.eslintignore no longer needs to ignore directories with no js files

Categories

(Firefox Build System :: Lint and Formatting, task, P1)

task

Tracking

(firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

When we first added ESLint, we added a few directories to the ignore list because it helped ESLint's performance.

I believe at some stage along the way, ESLint improved their indexing performance. Regardless, "including" these directories no longer gives any noticeable performance hit on my machine, so I think we should just include these.

It also will help prevent files sneaking into those directories that should be linted.

Due to these removals, ESLint is now enabled for build/pgo/index.html, so I'm adding a few extra fix ups to make that pass. I've not changed the formatting, since that will hopefully be done with prettier soon.

I'm also pulling the dom lines to the top of the file, since these are the only remaining general exclusions that we're still working on.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d2958471c08
eslintignore no longer needs to ignore directories with no js files. r=mossop
Backout by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/75d012801085
Backed out changeset 0d2958471c08 for spidermonkey bustages. CLOSED TREE
Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81b92cef1e23
eslintignore no longer needs to ignore directories with no js files. r=mossop
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.