1555301 - Comment in JSWindowActor.webidl makes little sense

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Kartikaya Gupta (email:[e-mail])]

https://searchfox.org/mozilla-central/rev/7556a400affa9eb99e522d2d17c40689fa23a729/dom/chrome-webidl/JSWindowActor.webidl#119-127

1. This is not intended properly
2. There is a typo s/much/must/
3. It doesn't make sense - what does it mean for observers in the list to use the nsGlobalWindowInner object as the topic? Isn't the topic a string? For somebody trying to populate this field in a call to ChromeUtils.registerWindowActor all they provide is a list of topics so where does the nsGlobalWindowInner come into play?

Comment 1

[John Dai[:jdai]]

Thanks for point this out. I'll check all of the comments. nsGlobalWindowInner comes from observer notification's subject.

Comment 2

[John Dai[:jdai]]

Attachment: Bug 1555301 - Fix JSWindowActor.webidl comments;

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9e1572a7737
Fix JSWindowActor.webidl comments; r=nika

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d9e1572a7737

Comment 5

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732