Closed Bug 1555329 Opened 1 year ago Closed 1 year ago

ICCv4 support broken in recent builds

Categories

(Core :: GFX: Color Management, defect, P2)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 + verified
firefox70 --- verified
firefox71 --- verified

People

(Reporter: aosmond, Assigned: aosmond)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(4 files)

Bug 1551084 had incomplete BGRA support for ICCv4. Bug 1255108 and bug 1255106 started using that broken functionality.

STR:

  1. Set gfx.color_management.enablev4 to true. Restart browser.
  2. Go to http://www.color.org/version4html.xalter.
  3. Note that the images appear as if ICCv4 support is missing.
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Has STR: --- → yes
Keywords: regression
OS: Unspecified → All
Priority: -- → P2
Regressed by: 1255108, 1255106, 1551084
Hardware: Unspecified → Desktop
Blocks: 1555331

:aosmond, could you try to find a regression range in using for example mozregression?

Ah, that's what happened to me today. I have no idea when I managed to enable this but images all over the place had black jagged outlines. This is a screenshot of the Google logo from their search page, also seen in lots of recent xkcd comics and the logo of a newsletter I get. tended to be "text in pictures" kinds of things.

If you don't have the setting enabled, or once this gets fixed, imagine the pale grey blocks around the letters were pitch black. NB: if you don't have the buggy setting enabled you may have to use "view image" from the context menu on the screenshot to see the artifacts.

Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc7e34460ec5
Fix BGRA support with ICCv4 QCMS profiles. r=miko
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Flags: qe-verify+

Confirmed issue with 69.0a1 (2019-05-29) on Windows 10.
Verified fix with 69.0b7 on Windows 10 and the image is rendered fine.

On macOS 10.14 and Ubuntu 18.04 with both 69.0b7 and current nightly build 70.a1; there are still some issues with the main image from step 2.
Will attach them bellow;

@Andrew do we need to file a new bug for those or is it something that can be fixed here?

Flags: needinfo?(aosmond)
Attached image 69.0b7_mac10.14.png

macOS screenshot.

Attached image 69.0b7_Ubuntu18.04.png

UbuntuOS screenshot.

The issue was reproduced on Windows 10, Nightly v69.0a1 (2019-05-30): The image appears as if "The system supports ICC version 2 profiles only" in both cases when the "gfx.color_management.enablev4" pref is false and true.

In the fixed builds, some improvements can definitely be observed when the "gfx.color_management.enabledv4" pref is "true"; more exactly image is displayed as the image in comment 8: the top-left, bottom-left and bottom-right corners are displayed decently, while the top-right corned is a bit blurry (the top-right quadrant profile is "v4 YCC-RGB").
This was verified on Nightly v71.0a1 (2019-09-04), Beta v70.0b3 and Release v69.0, on Windows 10, Mac OS 10.14 and Ubuntu 18.04.2.

Conclusion:
Improvements can definitely be observed, from the affected to the unaffected builds, so I will consider this issue verified, BUT it appears that the "v4 YCC-RGB" is still improperly displayed on Windows and Mac OS and the "v4 e-sRGB" and "v4 YCC-RGB" quadrants are improperly displayed on Ubuntu os (like in the pics of comment 8 and 9).

@Andrew, do you think that some follow-up bugs should be logged to address the remaining issues? Thanks!

Status: RESOLVED → VERIFIED
Flags: qe-verify+

There are a number of other bugs tracking the ICCv4 not rendering properly in general. We don't need to track them here.

Flags: needinfo?(aosmond)
You need to log in before you can comment on or make changes to this bug.