[wpt-sync] Sync PR 17068 - [LayoutNG] Eliminate source of self-collapsedness inconsistency.
Categories
(Core :: CSS Parsing and Computation, defect, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync upstream])
Sync web-platform-tests PR 17068 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/17068
Details from upstream follow.
Morten Stenshorne <mstensho@chromium.org> wrote:
[LayoutNG] Eliminate source of self-collapsedness inconsistency.
Remove an unnecessary check for border+padding logical height. No need
to test that separately, as border+padding is part of logical height,
which we would already have found to be positive at this point in that
case.After re-layout, NGBlockNode::CopyFragmentDataToLayoutBox() would update
self-collapsedness (UpdateIsSelfCollapsing()), but the percentage based
padding would be resolved against the old size of the containing block,
as LayoutNG hasn't gotten around to updating that yet (doesn't happen
until we finish layout of the containing block).Note that the test included used to pass with NG (if we bypassed the
DCHECK failure, that is).Bug: 967193
Change-Id: I9f35b598ea251ed2f7e1d5b44c1364f1aca17dbe
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/1634691
WPT-Export-Revision: 7eafcceaff76f776d1b0a741c4306d72b8132f53
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=192e645e70f44d2a2cffd33c9ec67fa341c1e05d
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=68acab55300d0e01ae640f201ffa00f10ee01c1d
Assignee | ||
Comment 3•5 years ago
|
||
Failed to get results from try push
Assignee | ||
Comment 4•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca4778551aeaa58cbd9ecadbe6ed54d203bbe21a
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/8f7ebea29a03 [wpt PR 17068] - [LayoutNG] Eliminate source of self-collapsedness inconsistency., a=testonly
Comment 6•5 years ago
|
||
bugherder |
Assignee | ||
Updated•5 years ago
|
Description
•