Closed Bug 1555368 Opened 5 months ago Closed 4 months ago

Firefox Monitor icon in location bar (and door hanger) doesn't adapt to dark theme UI

Categories

(Firefox :: Firefox Monitor, defect)

67 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 69
Tracking Status
firefox67 --- wontfix
firefox68 --- verified
firefox69 --- verified

People

(Reporter: amin.alhazwani, Assigned: nhnt11)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

  1. Go to https://bookmate.com/
  2. Firefox Monitor doorhanger showed up

Actual results:

The Firefox Monitor icon in the location bar and in the doorhanger is set to dark grey, the fill color doesn't reflect the the dark theme settings

Expected results:

The Firefox Monitor icon in the location bar and in the doorhanger is set to light grey, and reflects the dark theme settings

Component: Untriaged → Theme
Component: Theme → Firefox Monitor

The priority flag is not set for this bug.
:nhnt11, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(nhnt11)

Thanks for filing this! For some reason this SVG asset got landed with hard-coded fill and fill-opacity rather than context-.

Assignee: nobody → nhnt11
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(nhnt11)

The priority flag is not set for this bug.
:nhnt11, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(nhnt11)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/25a30e85d96d
Use context-{fill, fill-opacity} in Firefox Monitor icon. r=dao
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

We should probably uplift this.

Flags: qe-verify+

Comment on attachment 9073730 [details]
Bug 1555368 - Use context-{fill, fill-opacity} in Firefox Monitor icon. r=dao

Beta/Release Uplift Approval Request

  • User impact if declined: Inconsistent styling with the dark theme - icon looks out of place and overall makes Firefox look unprofessional
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes (by me, manually)
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is a very trivial change that ensures the icon's fill color is correct.
  • String changes made/needed: none
Flags: needinfo?(nhnt11)
Attachment #9073730 - Flags: approval-mozilla-beta?
QA Whiteboard: [qa-triaged]

I tested everything using latest Nightly 69.0a1 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The bug is not reproducing anymore.

Status: RESOLVED → VERIFIED

Comment on attachment 9073730 [details]
Bug 1555368 - Use context-{fill, fill-opacity} in Firefox Monitor icon. r=dao

fxmonitor icon fix for dark mode, approved for 68.0b14

Attachment #9073730 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I verified the fix on Firefox 68.0b14 using Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The bug is not reproducing anymore.

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.