Firefox Monitor icon in location bar (and door hanger) doesn't adapt to dark theme UI
Categories
(Firefox :: Firefox Monitor, defect)
Tracking
()
People
(Reporter: amin.alhazwani, Assigned: nhnt11)
Details
Attachments
(2 files)
131.33 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:67.0) Gecko/20100101 Firefox/67.0
Steps to reproduce:
- Go to https://bookmate.com/
- Firefox Monitor doorhanger showed up
Actual results:
The Firefox Monitor icon in the location bar and in the doorhanger is set to dark grey, the fill color doesn't reflect the the dark theme settings
Expected results:
The Firefox Monitor icon in the location bar and in the doorhanger is set to light grey, and reflects the dark theme settings
Updated•4 years ago
|
Updated•4 years ago
|
Comment 1•4 years ago
|
||
The priority flag is not set for this bug.
:nhnt11, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
Thanks for filing this! For some reason this SVG asset got landed with hard-coded fill
and fill-opacity
rather than context-
.
Assignee | ||
Updated•4 years ago
|
Comment 4•4 years ago
|
||
The priority flag is not set for this bug.
:nhnt11, could you have a look please?
For more information, please visit auto_nag documentation.
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/25a30e85d96d Use context-{fill, fill-opacity} in Firefox Monitor icon. r=dao
Comment 6•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 8•4 years ago
•
|
||
Comment on attachment 9073730 [details]
Bug 1555368 - Use context-{fill, fill-opacity} in Firefox Monitor icon. r=dao
Beta/Release Uplift Approval Request
- User impact if declined: Inconsistent styling with the dark theme - icon looks out of place and overall makes Firefox look unprofessional
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes (by me, manually)
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a very trivial change that ensures the icon's fill color is correct.
- String changes made/needed: none
Updated•4 years ago
|
Comment 9•4 years ago
|
||
I tested everything using latest Nightly 69.0a1 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The bug is not reproducing anymore.
Comment 10•4 years ago
|
||
Comment on attachment 9073730 [details]
Bug 1555368 - Use context-{fill, fill-opacity} in Firefox Monitor icon. r=dao
fxmonitor icon fix for dark mode, approved for 68.0b14
Comment 11•4 years ago
|
||
bugherderuplift |
Comment 12•4 years ago
|
||
I verified the fix on Firefox 68.0b14 using Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The bug is not reproducing anymore.
Description
•