1555368 - Firefox Monitor icon in location bar (and door hanger) doesn't adapt to dark theme UI

Status: VERIFIED FIXED

(Firefox :: Firefox Monitor, defect)

Description

[Amin Al Hazwani]

Attachment: firefox-monitor-doorhanger-screenshot.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

1. Go to https://bookmate.com/
2. Firefox Monitor doorhanger showed up

Actual results:

The Firefox Monitor icon in the location bar and in the doorhanger is set to dark grey, the fill color doesn't reflect the the dark theme settings

Expected results:

The Firefox Monitor icon in the location bar and in the doorhanger is set to light grey, and reflects the dark theme settings

Comment 1

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

The priority flag is not set for this bug.
:nhnt11, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Nihanth Subramanya [:nhnt11] [Slow responses till Oct 21]]

Attachment: Bug 1555368 - Use context-{fill, fill-opacity} in Firefox Monitor icon. r=dao

Comment 3

[Nihanth Subramanya [:nhnt11] [Slow responses till Oct 21]]

Thanks for filing this! For some reason this SVG asset got landed with hard-coded fill and fill-opacity rather than context-.

Comment 4

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

The priority flag is not set for this bug.
:nhnt11, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25a30e85d96d
Use context-{fill, fill-opacity} in Firefox Monitor icon. r=dao

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/25a30e85d96d

Comment 7

[Dão Gottwald [::dao]]

We should probably uplift this.

Comment 8

[Nihanth Subramanya [:nhnt11] [Slow responses till Oct 21]]

Comment on attachment 9073730 [details]
Bug 1555368 - Use context-{fill, fill-opacity} in Firefox Monitor icon. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: Inconsistent styling with the dark theme - icon looks out of place and overall makes Firefox look unprofessional
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes (by me, manually)
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a very trivial change that ensures the icon's fill color is correct.
• String changes made/needed: none

Comment 9

[Oana Botisan, Desktop Release QA]

I tested everything using latest Nightly 69.0a1 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The bug is not reproducing anymore.

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 9073730 [details]
Bug 1555368 - Use context-{fill, fill-opacity} in Firefox Monitor icon. r=dao

fxmonitor icon fix for dark mode, approved for 68.0b14

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a38e711fb744

Comment 12

[Oana Botisan, Desktop Release QA]

I verified the fix on Firefox 68.0b14 using Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The bug is not reproducing anymore.