1555371 - [about:addons] “Update” icon does not display properly for dark theme

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[CosminB]

Attachment: 2019-05-29_17h34_28.png

[Affected versions]:

• Firefox 69.0a1 (20190529065901)
• Firefox 68.0b5 (20190527103257)

[Affected platforms]:

• Win 7 64-bit
• Mac OS X 10.14.1

[Prerequisites]

• Config the browser from the description https://bugzilla.mozilla.org/show_bug.cgi?id=1551202#c0

[Steps to reproduce]:
1.Install a version of an extension that is not the latest, for example Version 1.6.5 https://addons.mozilla.org/en-US/firefox/addon/google-search-link-fix/versions/
2.Navigate to about:addons and click on “Extensions”
3.Check for updates.
4.Click on the more options button and observe the “Update”.

[Expected results]:

• The background is white and the arrow black.

[Actual results]:

• The background is black and the arrow is transparent.

Please see the attached screenshot.

Comment 1

[Julien Cristau [:jcristau]]

browser.in-content.dark-mode is only enabled in nightly afaik

Comment 2

[Kestrel]

Attachment: Bug 1555371 - Apply context fill to update icon for dark mode and do the same for all panel-items

Comment 3

[Kestrel]

Taking due to inactivity.

Comment 4

[Rob Wu [:robwu]]

Thanks for taking over Kestrel.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/113c5d9f6e49
Apply context fill to update icon for dark mode and do the same for all panel-items r=jaws

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/113c5d9f6e49

Comment 7

[CosminB]

Attachment: Bug1555371.png

This issue is verified as fixed on Firefox 69.0a1(20190620220631) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached screenshot.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Is this something we should backport to Beta before we ship 68 or can this fix ride the trains?

Comment 9

[Rob Wu [:robwu]]

This is a very minor patch with a well-understood (desired) effect, so the risk of uplifting is minimal (and uplifting means that the fix will also be on ESR68). So I would not object if someone else requests an uplift for this patch.

Note that this a minor appearance issue for a feature that is off by default (bug 1519547). Although it does not look as designed (before the fix), the bug does not significantly degrade the user experience (the menu item still has a legible text label that explains its purpose), so I don't mind if the patch just rides the train.