Closed Bug 1555371 Opened 2 years ago Closed 2 years ago

[about:addons] “Update” icon does not display properly for dark theme

Categories

(Toolkit :: Add-ons Manager, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox-esr68 --- wontfix
firefox67 --- disabled
firefox68 --- wontfix
firefox69 --- verified

People

(Reporter: cbadescu, Assigned: ke5trel)

References

Details

Attachments

(3 files)

Attached image 2019-05-29_17h34_28.png

[Affected versions]:

  • Firefox 69.0a1 (20190529065901)
  • Firefox 68.0b5 (20190527103257)

[Affected platforms]:

  • Win 7 64-bit
  • Mac OS X 10.14.1

[Prerequisites]

[Steps to reproduce]:
1.Install a version of an extension that is not the latest, for example Version 1.6.5 https://addons.mozilla.org/en-US/firefox/addon/google-search-link-fix/versions/
2.Navigate to about:addons and click on “Extensions”
3.Check for updates.
4.Click on the more options button and observe the “Update”.

[Expected results]:

  • The background is white and the arrow black.

[Actual results]:

  • The background is black and the arrow is transparent.

Please see the attached screenshot.

OS: Unspecified → All
Hardware: Unspecified → All
Assignee: nobody → rob
Priority: -- → P1
Summary: “Update” icon does not display properly for dark theme → [about:addons] “Update” icon does not display properly for dark theme

browser.in-content.dark-mode is only enabled in nightly afaik

Taking due to inactivity.

Assignee: rob → ke5trel

Thanks for taking over Kestrel.

Keywords: checkin-needed

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/113c5d9f6e49
Apply context fill to update icon for dark mode and do the same for all panel-items r=jaws

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Attached image Bug1555371.png

This issue is verified as fixed on Firefox 69.0a1(20190620220631) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached screenshot.

Status: RESOLVED → VERIFIED

Is this something we should backport to Beta before we ship 68 or can this fix ride the trains?

Flags: needinfo?(ke5trel)

This is a very minor patch with a well-understood (desired) effect, so the risk of uplifting is minimal (and uplifting means that the fix will also be on ESR68). So I would not object if someone else requests an uplift for this patch.

Note that this a minor appearance issue for a feature that is off by default (bug 1519547). Although it does not look as designed (before the fix), the bug does not significantly degrade the user experience (the menu item still has a legible text label that explains its purpose), so I don't mind if the patch just rides the train.

You need to log in before you can comment on or make changes to this bug.