1555378 - mach try fuzzy combined with --preset should allow editing the selected jobset in fzf

Status: RESOLVED WORKSFORME

(Developer Infrastructure :: Try, enhancement)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

STR:

./mach try fuzzy --preset=sm-shell 

Expected behaviour

the Fuzzy chooser fzf is launched, prepopulated with the jobs selected by the sm-shell prefix, allowing further refinement of a push

Actual behaviour

'fuzzy' doesn't seem to matter, and the same effect as mach try --preset=sm-shell happens: A push with the preset selected jobs.

Comment 1

[Andrew Halberstadt [:ahal]]

This ability already exists using the -i/--interactive flag. For ergonomic/implementation reasons, the default of -i will take the union of tasks that the preset selects, but you can use -x/--and to instead take the intersection.

In other words:

# select tasks in addition to the ones that 'sm-shell' selects
$ ./mach try --preset sm-shell -i

Or:

# further refine the tasks that 'sm-shell' selects
$ ./mach try --preset sm-shell -xi

There are ton of use cases to consider here, so the UI is admittedly a bit complicated. But I think this approach is more explicit than relying on the use of fuzzy or not, so I'm going to resolve WFM.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Ahhhhh. Thanks for the answer! It's definitely a bit cryptic, but I can get behind this.