Closed Bug 1555447 Opened 5 years ago Closed 5 years ago

Throw an exception with more diagnostic information when LaunchAndroidService will fail

Categories

(GeckoView :: General, defect, P1)

Product:
GeckoView
Component:
General
Platform:
All
Android
Type:
defect

Tracking

(firefox67 wontfix, firefox67.0.1 wontfix, firefox68 fixed, firefox69 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox67 --- wontfix
firefox67.0.1 --- wontfix
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: cpeterson, Assigned: droeh)

References

Details

(Whiteboard: [geckoview:fenix:m6])

Attachments

(1 file)

Bug 1555447 - Throw exceptions rather than returning 0 from GeckoProcessManager.java r=rbarker!
47 bytes, text/x-phabricator-request
jcristau
: approval-mozilla-beta+
Details | Review

Bug 1548525 added code to properly handle error codes returned from LaunchAndroidService, but it doesn't fix the root cause of these content process errors. snorp suggests GV crash itself closer to the error so we can stuff more diagnostic information in an exception report.

Assignee: nobody → droeh
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15072106937d
Throw exceptions rather than returning 0 from GeckoProcessManager.java r=rbarker

https://hg.mozilla.org/mozilla-central/rev/15072106937d

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Comment on attachment 9069778 [details]
Bug 1555447 - Throw exceptions rather than returning 0 from GeckoProcessManager.java r=rbarker!

Beta/Release Uplift Approval Request

  • User impact if declined: No immediate user impact; the purpose of this is to get better crash reporting for a top crasher so we can figure out what's happening.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: N/A; we don't have steps to reproduce this crash in the first place.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It simply throws rather than returning an invalid pid from GeckoProcessManager.start() -- we'll crash either way, but with this patch we should have additional information in the crash report.
  • String changes made/needed: N/A
Attachment #9069778 - Flags: approval-mozilla-beta?

I filed new bug 1557449 to track the actual CreateEndpoint crash.

Blocks: 1548525
Crash Signature: [@ mozilla::ipc::CreateEndpoints<T>] [@ mozilla::layers::PCompositorManager::CreateEndpoints]
No longer depends on: 1548525
Blocks: 1557449

Comment on attachment 9069778 [details]
Bug 1555447 - Throw exceptions rather than returning 0 from GeckoProcessManager.java r=rbarker!

gv fix for 68.0b9

Attachment #9069778 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: