Closed Bug 1555480 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 17082 - Reland tests from "Change ICE connection state on transceiver changes"

Categories

(Core :: WebRTC, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 17082 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17082
Details from upstream follow.

Harald Alvestrand <hta@chromium.org> wrote:

Reland tests from "Change ICE connection state on transceiver changes"

This reverts the rest of commit 2229f484784131f7c655c650b389cfd78fe3e739.

Reason for revert: Fixed the test.

Original change's description:

Revert "Change ICE connection state on transceiver changes"

This reverts commit 0882bebe06b38aa5d4e155a5cebc11e7af08abd2.

Reason for revert: Causing flaky failures of
external/wpt/webrtc/RTCPeerConnection-iceConnectionState.https.html
on Linux Tests and WebKit Linux Trusty Leak

https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/78387
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak/34892

Original change's description:

Change ICE connection state on transceiver changes

This ensures that if the PC iceConnectionState should change
because unused transports are discarded, the state is updated.

Bug: chromium:966798

Change-Id: I09d945f5e70eec813f33c3131fbe889825613652
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632254
Reviewed-by: Henrik Boström \<hbos@chromium.org>
Commit-Queue: Harald Alvestrand \<hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664206}

TBR=hta@chromium.org,hbos@chromium.org

Change-Id: I2cbae9f1327e7aacb7022d2a823ce1e954c91b62
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:966798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635208
Reviewed-by: Aaron Gable \<agable@chromium.org>
Commit-Queue: Aaron Gable \<agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664388}

Bug: chromium:966798
Change-Id: I2e9887bc62942393a2d39042da9bfc85bbd98c91

Reviewed-on: https://chromium-review.googlesource.com/1636049
WPT-Export-Revision: 2c9703afb828f2da63e2d559f9ecd843c6f6abb3

PR 17082 applied with additional changes from upstream: 38f02ed8bb05f69ab4b061d17220f8f46709a0a3, 4b753c19e98803828b8c668b38ff5a81c18bb414, 41b56a8719cfed2fe871d0320fee3a469a24dae2, e9e9db16901ee98027f910967f5bae70bb545fe6, cdbf9b5a40c6dba3c57691b9123dde557b7d862c
Component: web-platform-tests → WebRTC
Product: Testing → Core
PR 17082 applied with additional changes from upstream: 6cdf2654f9345427e41e40a0f3e47f9e0003ea6c, 38f02ed8bb05f69ab4b061d17220f8f46709a0a3, 4b753c19e98803828b8c668b38ff5a81c18bb414, 41b56a8719cfed2fe871d0320fee3a469a24dae2, e9e9db16901ee98027f910967f5bae70bb545fe6, 19f06191aaa7465c649806dd0044cc21d064710f, cdbf9b5a40c6dba3c57691b9123dde557b7d862c, 80853e045ef85c804e639570690481db6e15a53e
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/6f9ec0473c05 [wpt PR 17082] - Reland tests from "Change ICE connection state on transceiver changes", a=testonly
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.