Closed Bug 1555482 Opened 5 months ago Closed 4 months ago

Remove strings-import, bundle:locales and imported strings (locales-src/ subdirectories)

Categories

(Firefox :: New Tab Page, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 69
Iteration:
69.4 - Jun 24 - Jul 7
Tracking Status
firefox69 --- fixed

People

(Reporter: k88hudson, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

After other prerendering removal work, we should remove any references to prerendering (such as gActivityStreamPrerenderedState) that remain in the repository and documentation.

As pointed by Ed over slack, after prerendering removal clean up below for prerendering references

  1. content-src
  2. build (webpack, jar)
  3. strings (import, locales-src)
  4. about new tab service

Looks like there's enough bugs already, so I'll just morph some of them…

(In reply to Punam Dahiya [:pdahiya] from comment #1)

  1. content-src

converting bug 1553375 to clean up prerendered references in content-src, common and lib

  1. build (webpack, jar)

bug 1555393

  1. strings (import, locales-src)

converting this bug

  1. about new tab service

bug 1555450

Summary: Remove any unused references prerendering → Remove strings-import and imported strings (locales-src)

Like bug 1555450, this bug can only happen after we no longer need properties/json strings (pulled in via strings-import and generated with pontoon-to-json respectively). We can also get rid of pontoon-to-json and data/locales.json and locale related stuff in bin/render-activity-stream-html.js

See Also: → 1555450
Iteration: --- → 69.2 - May 27 - Jun 9
Priority: -- → P2
Iteration: 69.2 - May 27 - Jun 9 → 69.3 - Jun 10 - 23
Type: enhancement → task
Iteration: 69.3 - Jun 10 - 23 → ---
Blocks: ujmc

This can't happen until we we no longer depend on data/locales.json generated by pontoon-to-json

Depends on: 1555450
Component: Activity Streams: Newtab → New Tab Page
Summary: Remove strings-import and imported strings (locales-src) → Remove strings-import, bundle:locales and imported strings (locales-src/ subdirectories)
Assignee: nobody → edilee
Iteration: --- → 69.4 - Jun 24 - Jul 7
Priority: P2 → P1
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7dcdb13f0c8e
Remove strings-import, bundle:locales and imported strings (locales-src/ subdirectories) r=k88hudson
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.