1555485 - Include XPConnect method information in crash reports

Status: NEW

(Core :: XPConnect, defect, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

This should help with determining what causes a crash when errors occur in this translation layer, or in other old internal JS/C++ code which communicates through XPConnect-wrapped methods.

No XPConnect methods are exposed to the web, so this should not leak private information about what website is being visited.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1555485 - Include XPConnect method information in crash reports,

This should help with determining what causes a crash when errors occur in this
translation layer, or in other old internal JS/C++ code which communicates
through XPConnect-wrapped methods.

This patch adds a chain of annotation information to the crash report containing
the interface name, method name, and direction of all XPConnect-mediated calls
currently on the stack.

No XPConnect methods are exposed to the web, so this should not leak private
information about what website is being visited.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: xpconnect_crash_request.md

Under the assumption I will need data-review for this, I filled out the form and am requesting data-review from :chutten.

Comment 3

[Chris H-C :chutten]

Comment on attachment 9068541 [details]
xpconnect_crash_request.md

Redirecting to megan to share the fun.

Comment 4

[Megan McCorquodale]

Comment on attachment 9068541 [details]
xpconnect_crash_request.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

This will be documented in the probe dictionary. 

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This data is opt in at time of crash. 

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No, but this data will be available in Soccorro.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, technical data. 

    Is the data collection request for default-on or default-off?

Default-on.

    Does the instrumentation include the addition of any new identifiers?

No new identifiers.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No renewal needed. 

---
Result: datareview+