1555486 - [wpt-sync] Sync PR 17083 - [web-animations] Make handling of keyframes more spec compliance

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 17083 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17083
Details from upstream follow.

Majid Valipour <[e-mail]> wrote:

[web-animations] Make handling of keyframes more spec compliance

WebAnimations spec has two keyframe concepts:

A) keyframes [1]
B) computed keyframes [2]

A key difference is that in A property values remain unresolved while in
B these properties are resolved (e.g., shorthands expand to long hands
etc.)

KeyframeEffect.getKeyframes() is expected to return (A) but our current
implementation only keeps around (B).

This CL introduces the following changes to bring us closer to the
specified behavior:

1. Introduce a new vector \<property, value> in StringKeyframe
   representing (A)
2. CSS property pairs are added to this list as long as they parse
   correctly [3]
3. Use the new vector to produce the result of getKeyframes()

Note that we continue our old behavior for SVG and Presentation attrs
which will be switch over in follow up patch.

[1] https://drafts.csswg.org/web-animations/#keyframes-section
[2] https://drafts.csswg.org/web-animations/#calculating-computed-keyframes
[3] https://drafts.csswg.org/web-animations/#process-a-keyframes-argument step 8

TEST:

• web-animations/interfaces/{Animatable, Keyframes} => PASS previously failing tests
• Added two new test cases covering animated custom props

Bug: 816956
Change-Id: Icc8e0bc4a0ee3019ad7d2c566aacb9d3aee0ffe3
Reviewed-on: https://chromium-review.googlesource.com/1634393
WPT-Export-Revision: cc79534ee2946219d2e811a63a48cfd3dac5fa75

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=02904b09222750c6b7f85788847f63ea79bd3029

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=90ce864a21a84f0d4bc76ad929038ac255e99c8d

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f0d29829abcac126cf7be00f43ab0a9e1dfe5e8

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0698a46b490c438c75c992e3872cc39febf420d

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8266f34ab168d2fee37e16d2529af7752c800da5

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=3872035e1a344e80992e8e43bd0078b441a0e801

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7625dde77af74a75656eaf759c268b99b83e31b4

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to get results from try push

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e69774b6503
[wpt PR 17083] - [web-animations] Make handling of keyframes more spec compliant, a=testonly

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/7e69774b6503