1555518 - [wasm] Debugger cannot stop or debug wasm files with maps

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Yury Delendik (:yury)]

STR:

1. Open https://yurydelendik.github.io/old-man-sandbox/fibdbg/fib2_o0.html
2. Open debugger and refresh page (to see .wasm and .c files)
3. In Sources, find and open .c file
4. Place breakpoint at line 5 a = b;
5. Refresh the page
6. Optional
   a) Use "Jump to generated location"
   b) Then, use "Jump to original location"

Expected:

• Debugger breaks at line 5
• Stack shows "fib" function
• To see original .wasm file and jump back to .c (see step 6)

Actual:

• Stack and source editor does not show where it is paused
• "Jump to original location" does not work

Comment 1

[Yury Delendik (:yury)]

Attachment: Fixes original stack display for wasm files, and ref to original source.

• Fixes expandFrames() to ensure the thread property is set
• Refactors getSourceLocationFromMouseEvent to use fromEditorLine
• Replaces dwarf_to_json (for proper DWARF conversion)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95ffb38f6a64
Fixes original stack display for wasm files, and ref to original source. r=jlast

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 95ffb38f6a64 (bug 1555518) for Debugger failure. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249393164&repo=autoland&lineNumber=581

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=95ffb38f6a64d7cc5ccacc8080c9928027155be3

Backout:
https://hg.mozilla.org/integration/autoland/rev/da7de725195576687e821ecffd29c7886e2edc3d

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70fa4fef28c6
Fixes original stack display for wasm files, and ref to original source. r=jlast

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/70fa4fef28c6