Closed Bug 1555608 Opened 1 year ago Closed 1 year ago

The imip bar toolbarbuttons aren't showing labels

Categories

(Calendar :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 69.0

People

(Reporter: mkmelin, Assigned: mkmelin)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1547233 +++

The imip bar toolbarbuttons aren't showing labels on trunk.
This is apparently because the toolbarbuttons doesn't react properly to setting hidden.

To check, open an email with an event invite. Notice that before the toolbarbuttons for accept/tenative/decline were not showing properly. With the patch they show the label as they should.

Attachment #9068636 - Flags: review?(khushil324)
Comment on attachment 9068636 [details] [diff] [review]
bug1555608_imip_toolbarbuttons.patch

Review of attachment 9068636 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. r=khushil.
Attachment #9068636 - Flags: review?(khushil324) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/6b95c43c6c89
make toolbarbutton-menu-button work with setting the hidden attribute. r=khushil

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED

Needs 7.1

Flags: needinfo?(philipp)
Target Milestone: --- → 7.0
Flags: needinfo?(philipp)
Target Milestone: 7.0 → 7.1
You need to log in before you can comment on or make changes to this bug.