Closed Bug 1555627 Opened 6 months ago Closed 6 months ago

"Learn more…" hyperlink doesn't work in some "Secure Connection Failed" error website pages

Categories

(Firefox :: Security, defect, P1, major)

68 Branch
x86_64
Windows 7
defect

Tracking

()

VERIFIED FIXED
Firefox 69
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox67.0.1 --- unaffected
firefox68 + verified
firefox69 + verified

People

(Reporter: Virtual, Assigned: johannh)

References

(Regression)

Details

(Keywords: nightly-community, regression, reproducible)

Attachments

(4 files)

Attached image no bug - Firefox 67.png

STR:

  1. Open https://www.teknik.io/ website page
  2. Get this error (for now, it will be fixed shortly)

Secure Connection Failed

An error occurred during a connection to www.teknik.io. PR_CONNECT_RESET_ERROR

The page you are trying to view cannot be shown because the authenticity of the received data could not be verified.
Please contact the website owners to inform them of this problem.

Learn more…

Try Again

Report errors like this to help Mozilla identify and block malicious sites

  1. Press "Learn more..." hyperlink
    and see that it doesn't work, as nothing opened

:Virtual, could you try to find a regression range in using for example mozregression?

Attached file mozregression GUI.txt

(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #2)

:Virtual, could you try to find a regression range in using for example
mozregression?

Done, mozregression GUI pointing me to:

Found commit message:
Backed out 2 changesets (bug 1544651, bug 1544648) for bustages on Nursery.cpp . CLOSED TREE

Backed out changeset 2f61be416873 (bug 1544648)
Backed out changeset 7699a6645860 (bug 1544651)
which is probably false in this case, as there were many "Skipping build" messages.

@ Johann Hofmann [:johannh] - per

(Johann Hofmann [:johannh] wrote in bug #1545743 in comment #7)

I'm not sure when this actually regressed but I know how to fix it.

Please, could you also look on this bug? Thanks.

Flags: needinfo?(jhofmann)
Version: 69 Branch → 68 Branch
Component: Theme → Security
See Also: → 1556584

PR_END_OF_FILE_ERROR error page does not have a working "Learn More" too.
Example: https://www2.ensc.sfu.ca/

Together with the info at bug 1556584, I guess all broken "Learn More" are still using the old certificate error page. These pages do not have big yellow warning borders, and the wordings are different.

(Fanolian in bug #1556584 comment #0 wrote)

Learn more… does not contain a link for some error pages, particularly:
SEC_ERROR_REVOKED_CERTIFICATE: [revoked] (https://revoked.badssl.com/)
SSL_ERROR_NO_CYPHER_OVERLAP: [null] (https://null.badssl.com/), rc4, [rc4-md5] (https://rc4-md5.badssl.com/)
SSL_ERROR_WEAK_SERVER_EPHEMERAL_DH_KEY: [dh512] (https://dh512.badssl.com/), [dh480] https://dh480.badssl.com/)
MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE: [pinning-test] (https://pinning-test.badssl.com/)

Has Regression Range: --- → yes
See Also: 1556584
Summary: "Learn more…" hyperlink doesn't work in "Secure Connection Failed" error website page at "PR_CONNECT_RESET_ERROR" error → "Learn more…" hyperlink doesn't work in some "Secure Connection Failed" error website pages
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Flags: needinfo?(jhofmann)
Priority: -- → P1
Regressed by: 1284835

Bug 1284835 removed the hard-coded learn more link on cert and net error pages, which worked
for cert error pages because they explicitly set their own learn more links, but net error
pages were relying on the default href to be set. This wasn't revealed until bug 1530348
made about:neterror part of the new error pages.

The solution is simply to explicitly set the correct learn more link to net error pages.

Note that in the case of PR_END_OF_FILE errors, we were not previously showing a "learn more"
link. That was not intentional, as far as I can tell, but was caused by the bug fixed in bug 1477875.

Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/afa85396e41c
Set a learn more link on net error pages. r=prathiksha
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

Comment on attachment 9072487 [details]
Bug 1555627 - Set a learn more link on net error pages. r=prathiksha

Beta/Release Uplift Approval Request

  • User impact if declined: Broken Learn More links on some error pages
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Visit the websites mentioned in comment 5 and comment 6, they should have functioning "Learn More" links.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Extremely simple front-end patch that adds additional test coverage.
  • String changes made/needed: None
Attachment #9072487 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

I successfully reproduced the issue on Firefox Nightly 69.0a1 (2019-05-30) under Windows 10 (x64) using the STR from Comment 0 and the link from Comment 5.

The issue is no longer reproducible on Latest Nightly 69.0a1 (2019-06-23). Tests were performed on Windows 10 (x64), Ubuntu 18.04 (x64) and macOS 10.13.

Status: RESOLVED → VERIFIED

Comment on attachment 9072487 [details]
Bug 1555627 - Set a learn more link on net error pages. r=prathiksha

Fix was verified in Nightly, recent regression, Beta68+

Attachment #9072487 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

As OP I'm also confirming that bug is fixed, starting in Mozilla Firefox Nightly 69.0a1 (2019-06-21) and in latest Mozilla Firefox Beta 68.0.
Thank you very much! \o/

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.