Crash in [@ AsyncShutdownTimeout | AddonManager: Waiting for providers to shut down. | EnvironmentAddonBuilder]

RESOLVED FIXED in Firefox -esr68

Status

()

defect
--
critical
RESOLVED FIXED
2 months ago
6 days ago

People

(Reporter: philipp, Assigned: kmag)

Tracking

({crash, regression})

68 Branch
mozilla69
All
Windows
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox-esr68 fixed, firefox67 unaffected, firefox67.0.1 unaffected, firefox68 fixed, firefox69 fixed)

Details

(crash signature)

Attachments

(1 attachment)

This bug is for crash report bp-b93acb00-c7f8-4c79-aaa3-d469b0190530.

AsyncShutdownTimeout:

{
    "phase":"AddonManager: Waiting for providers to shut down.",
    "conditions":[
        {
            "name":"EnvironmentAddonBuilder",
            "state":"(none)",
            "filename":"resource://gre/modules/TelemetryEnvironment.jsm",
            "lineNumber":562,
            "stack":[
                "resource://gre/modules/TelemetryEnvironment.jsm:init:562",
                "resource://gre/modules/TelemetryEnvironment.jsm:EnvironmentCache:947",
                "resource://gre/modules/TelemetryEnvironment.jsm:getGlobal:74",
                "resource://gre/modules/TelemetryEnvironment.jsm:get currentEnvironment:81",
                "resource://gre/modules/TelemetryStartup.jsm:annotateEnvironment:37",
                "resource://gre/modules/TelemetryStartup.jsm:TelemetryStartup.prototype.observe:27"
            ]
        }
    ]
}

this crash signature on shutdown is spiking up in the 68 cycle from firefox installations on windows - on 68.0b5 this is currently accounting for 2% of browser crashes.

the first affected nightly build was 68.0a1 build 20190331090052, the pushlog contains a couple of changes that might be related here:

Flags: needinfo?(kmaglione+bmo)

The AddonManager.shutdown barrier blocks the final phase of AddonManager
shutdown, which means that things which use it to mean "I need to do this
before the add-on manager shuts down" are generally broken.

This patch adds a separate beforeShutdown barrier which blocks the start of
provider shutdown, and changes existing broken consumers to use it. It also
renames the existing barrier to AddonManagerPrivate.finalShutdown to make it
clearer a) what it does, and b) that only internal AddonManager code should
use it.

https://hg.mozilla.org/integration/mozilla-inbound/rev/678144498f35fd4ffafe8f0ddf5f64143d380dcb
Bug 1555632: Add separate AddonManager.beforeShutdown barrier and use where appropriate. r=aswan

Backed out changeset 678144498f35 (bug 1555632) for talos failures.

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/d0e348e8709fcf55f4ccde22a09ca2283d5e6426

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&revision=678144498f35fd4ffafe8f0ddf5f64143d380dcb&selectedJob=250451744

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250451744&repo=mozilla-inbound&lineNumber=2751

Log snippet:

19:59:25 INFO - WARN: compileToBinary(259):
19:59:25 INFO - C:\fakepath(337,18-133): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
19:59:25 INFO - C:\fakepath(343,62-116): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
19:59:25 INFO - C:\fakepath(366,75-84): warning X3556: integer divides may be much slower, try using uints if possible.
19:59:25 INFO - C:\fakepath(369,50-59): warning X3556: integer modulus may be much slower, try using uints if possible.
19:59:25 INFO - C:\fakepath(385,33-90): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
19:59:25 INFO - C:\fakepath(174,1-6): warning X4000: use of potentially uninitialized variable (dyn_index_vec4_float4)
19:59:25 INFO - C:\fakepath(289,25-29): error X4576: Input array signature parameter SV_Position cannot be indexed dynamically.
19:59:25 INFO - WARN: compileToBinary(259):
19:59:25 INFO - C:\fakepath(366,75-84): warning X3556: integer divides may be much slower, try using uints if possible.
19:59:25 INFO - C:\fakepath(369,50-59): warning X3556: integer modulus may be much slower, try using uints if possible.
19:59:25 INFO - C:\fakepath(174,1-6): warning X4000: use of potentially uninitialized variable (dyn_index_vec4_float4)
19:59:25 INFO - C:\fakepath(225,1): warning X4000: use of potentially uninitialized variable (f_distance_aa)
19:59:25 INFO - C:\fakepath(262,1): warning X4000: use of potentially uninitialized variable (f_do_clip)
19:59:26 INFO - [Child 7064, Chrome_ChildThread] WARNING: pipe error: 109: file z:/task_1559838951/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
19:59:26 INFO - [Child 7064, Chrome_ChildThread] WARNING: pipe error: 109: file z:/task_1559838951/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
19:59:26 INFO - [Parent 5532, Gecko_IOThread] WARNING: file z:/task_1559838951/build/src/ipc/chromium/src/base/process_util_win.cc, line 160
19:59:26 INFO - __metrics Screen width/height: 1024/768
19:59:26 INFO - colorDepth: 24
19:59:26 INFO - Browser inner width/height: 1012/687
19:59:26 INFO - __metrics
19:59:26 INFO - WebGL(0000024E777B7000)::ForceLoseContext
19:59:26 INFO - WebGL(0000024E777B9000)::ForceLoseContext
19:59:26 ERROR - about:support {"application":{"name":"Firefox","osVersion":"Windows_NT 10.0","version":"69.0a1","buildID":"20190606180853","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0","safeMode":false,"updateChannel":"nightly-mozilla-inbound","supportURL":"https://support.mozilla.org/1/firefox/69.0a1/WINNT/en-US/","numTotalWindows":1,"numRemoteWindows":1,"launcherProcessState":0,"remoteAutoStart":true,"autoStartStatus":1,"policiesStatus":0,"keyLocationServiceGoogleFound":true,"keySafebrowsingGoogleFound":true,"keyMozillaFound":true},"securitySoftware":{"registeredAntiVirus":"","registeredAntiSpyware":"","registeredFirewall":""},"processes":{"remoteTypes":{"extension":1,"web":2,"gpu":1},"maxWebContentProcesses":8},"modifiedPreferences":{"browser.cache.disk.filesystem_reported":1,"browser.cache.disk.smart_size.enabled":false,"browser.link.open_newwindow":2,"browser.startup.homepage_override.mstone":"69.0a1","browser.startup.homepage_override.buildID":"20190606180853","browser.tabs.remote.autostart":true,"browser.urlbar.userMadeSearchSuggestionsChoice":true,"dom.forms.autocomplete.formautofill":true,"dom.allow_scripts_to_close_windows":true,"dom.disable_open_during_load":false,"dom.disable_window_flip":true,"dom.disable_window_move_resize":true,"dom.max_chrome_script_run_time":0,"dom.max_script_run_time":0,"dom.push.connection.enabled":false,"dom.send_after_paint_to_content":true,"extensions.checkCompatibility":false,"extensions.lastAppVersion":"69.0a1","general.useragent.updates.enabled":false,"gfx.crash-guard.wmfvpxvideo.deviceID":"0x193a","gfx.crash-guard.status.wmfvpxvideo":2,"gfx.crash-guard.wmfvpxvideo.driverVersion":"22.20.16.4815","gfx.crash-guard.wmfvpxvideo.appVersion":"69.0a1","gfx.webrender.all.qualified":false,"idle.lastDailyNotification":-1,"layers.mlgpu.sanity-test-failed":false,"media.allowed-to-play.enabled":true,"media.autoplay.ask-permission":false,"media.autoplay.block-webaudio":false,"media.autoplay.default":0,"media.autoplay.enabled.user-gestures-needed":true,"media.capturestream_hints.enabled":true,"media.gmp-manager.updateEnabled":false,"media.gmp-manager.url":"http://127.0.0.1/gmpmanager-dummy/update.xml","media.gmp.storage.version.observed":1,"media.hardware-video-decoding.failed":false,"media.libavcodec.allow-obsolete":true,"media.navigator.enabled":true,"media.navigator.permission.disabled":true,"media.peerconnection.enabled":true,"network.http.speculative-parallel-limit":0,"places.history.expiration.transient_current_max_pages":112348,"places.database.lastMaintenance":2147483647,"plugin.disable_full_page_plugin_for_types":"application/pdf","plugin.state.flash":0,"plugins.flashBlock.enabled":false,"privacy.sanitize.pending":"[{\"id\":\"newtab-container\",\"itemsToClear\":[],\"options\":{}}]","privacy.reduceTimerPrecision":false,"privacy.trackingprotection.annotate_channels":false,"privacy.trackingprotection.enabled":false,"privacy.trackingprotection.introURL":"http://127.0.0.1/trackingprotection/tour","privacy.trackingprotection.pbmode.enabled":false,"security.certerrors.mitm.priming.enabled":false,"security.enable_java":false,"security.fileuri.strict_origin_policy":false,"security.sandbox.content.tempDirSuffix":"{ec7560b6-7975-4e49-890c-4a1bf7e9bcb6}","security.sandbox.plugin.tempDirSuffix":"{c825b33e-68d6-43f5-8073-5aa46ed8a14f}","security.turn_off_all_security_so_that_viruses_can_take_over_this_computer":true,"services.sync.engine.addresses.available":true},"lockedPreferences":{},"media":{"currentAudioBackend":"unknown","currentMaxAudioChannels":0,"currentPreferredSampleRate":44100,"audioOutputDevices":[],"audioInputDevices":[]},"javaScript":{"incrementalGCEnabled":true},"accessibility":{"isActive":false,"forceDisabled":0,"handlerUsed":false,"instantiator":""},"libraryVersions":{"NSPR":{"minVersion":"4.21","version":"4.21"},"NSS":{"minVersion":"3.45 Beta","version":"3.45 Beta"},"NSSUTIL":{"minVersion":"3.45 Beta","version":"3.45 Beta"},"NSSSSL":{"minVersion":"3.45 Beta","version":"3.45 Beta"},"NSSSMIME":{"minVersion":"3.45 Beta","version":"3.45 Beta"}},"userJS":{"exists":true},"intl":{"localeService":{"requested":["en-US"],"available":["en-US"],"supported":["en-US"],"regionalPrefs":["en-US"],"defaultLocale":"en-US"},"osPrefs":{"systemLocales":["en-US"],"regionalPrefsLocales":["en-US"]}},"crashes":{"submitted":[],"pending":0},"sandbox":{"contentSandboxLevel":5,"effectiveContentSandboxLevel":5},"graphics":{"numTotalWindows":1,"numAcceleratedWindows":1,"windowLayerManagerType":"WebRender","windowLayerManagerRemote":true,"windowUsingAdvancedLayers":false,"adapterDescription":"Intel(R) Iris(R) Pro Graphics P580","adapterVendorID":"0x8086","adapterDeviceID":"0x193a","adapterSubsysID":"18a9103c","adapterRAM":"Unknown","adapterDrivers":"igdumdim64 igd10iumd64 igd10iumd64 igd12umd64 igdumdim32 igd10iumd32 igd10iumd32 igd12umd32","driverVendor":"","driverVersion":"22.20.16.4815","driverDate":"9-26-2017","adapterDescription2":"","adapterVendorID2":"","adapterDeviceID2":"","adapterSubsysID2":"","adapterRAM2":"","adapterDrivers2":"","driverVendor2":"","driverVersion2":"","driverDate2":"","isGPU2Active":false,"direct2DEnabled":true,"directWriteEnabled":true,"directWriteVersion":"10.0.15063.0","clearTypeParameters":"Gamma: 1.8 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 50 ","usesTiling":false,"contentUsesTiling":true,"offMainThreadPaintEnabled":true,"offMainThreadPaintWorkerCount":4,"targetFrameRate":60,"webgl1Renderer":"Google Inc. -- ANGLE (Intel(R) Iris(R) Pro Graphics P580 Direct3D11 vs_5_0 ps_5_0)","webgl1Version":"OpenGL ES 2.0 (ANGLE 2.1.0.1d5494fc3e85)","webgl1DriverExtensions":"GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_explicit_context GL_ANGLE_explicit_context_gles1 GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_memory_size GL_ANGLE_multi_draw GL_ANGLE_multiview_multisample GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_provoking_vertex GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_func_extended GL_EXT_blend_minmax GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_float_blend GL_EXT_frag_depth GL_EXT_instanced_arrays GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_bptc GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_KHR_parallel_shader_compile GL_KHR_robust_buffer_access_behavior GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_border_clamp GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object OES_compressed_EAC_R11_signed_texture OES_compressed_EAC_R11_unsigned_texture OES_compressed_EAC_RG11_signed_texture OES_compressed_EAC_RG11_unsigned_texture OES_compressed_ETC2_RGB8_texture OES_compressed_ETC2_RGBA8_texture OES_compressed_ETC2_punchthroughA_RGBA8_texture OES_compressed_ETC2_punchthroughA_sRGB8_alpha_texture OES_compressed_ETC2_sRGB8_alpha8_texture OES_compressed_ETC2_sRGB8_texture ","webgl1Extensions":"ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_disjoint_timer_query EXT_float_blend EXT_frag_depth EXT_shader_texture_lod EXT_sRGB EXT_texture_compression_bptc EXT_texture_filter_anisotropic OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context","webgl1WSIInfo":"EGL_VENDOR: Google Inc. (adapter LUID: 0000000000006d99)\nEGL_VERSION: 1.4 (ANGLE 2.1.0.1d5494fc3e85)\nEGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control EGL_ANGLE_robust_resource_initialization EGL_ANGLE_create_context_extensions_enabled EGL_ANDROID_blob_cache EGL_ANDROID_recordable \nEGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses EGL_KHR_debug EGL_ANGLE_explicit_context ","webgl2Renderer":"Google Inc. -- ANGLE (Intel(R) Iris(R) Pro Graphics P580 Direct3D11 vs_5_0 ps_5_0)","webgl2Version":"OpenGL ES 3.0 (ANGLE 2.1.0.1d5494fc3e85)","webgl2DriverExtensions":"GL_ANGLE_client_arrays GL_ANGLE_copy_texture_3d GL_ANGLE_depth_texture GL_ANGLE_explicit_context GL_ANGLE_explicit_context_gles1 GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_memory_size GL_ANGLE_multi_draw GL_ANGLE_multiview_multisample GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_provoking_vertex GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_multisample GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_func_extended GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_float_blend GL_EXT_frag_depth GL_EXT_instanced_arrays GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_bptc GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_KHR_parallel_shader_compile GL_KHR_robust_buffer_access_behavior GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_border_clamp GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object GL_OVR_multiview2 OES_compressed_EAC_R11_signed_texture OES_compressed_EAC_R11_unsigned_texture OES_compressed_EAC_RG11_signed_texture OES_compressed_EAC_RG11_unsigned_texture OES_compressed_ETC2_RGB8_texture OES_compressed_ETC2_RGBA8_texture OES_compressed_ETC2_punchthroughA_RGBA8_texture OES_compressed_ETC2_punchthroughA_sRGB8_alpha_texture OES_compressed_ETC2_sRGB8_alpha8_texture OES_compressed_ETC2_sRGB8_texture ","webgl2Extensions":"EXT_color_buffer_float EXT_disjoint_timer_query EXT_float_blend EXT_texture_compression_bptc EXT_texture_filter_anisotropic OES_texture_float_linear WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context","webgl2WSIInfo":"EGL_VENDOR: Google Inc. (adapter LUID: 0000000000006d99)\nEGL_VERSION: 1.4 (ANGLE 2.1.0.1d5494fc3e85)\nEGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control EGL_ANGLE_robust_resource_initialization EGL_ANGLE_create_context_extensions_enabled EGL_ANDROID_blob_cache EGL_ANDROID_recordable \nEGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses EGL_KHR_debug EGL_ANGLE_explicit_context ","info":{"AzureCanvasBackend (UI Process)":"skia","AzureFallbackCanvasBackend (UI Process)":"cairo","AzureContentBackend (UI Process)":"skia","AzureCanvasBackend":"direct2d 1.1","AzureContentBackend":"skia","ApzWheelInput":1,"ApzDragInput":1,"ApzKeyboardInput":1,"ApzAutoscrollInput":1,"CMSOutputProfile":"AAAMSExpbm8CEAAAbW50clJHQiBYWVogB84AAgAJAAYAMQAAYWNzcE1TRlQAAAAASUVDIHNSR0IAAAAAAAAAAAAAAAAAAPbWAAEAAAAA0y1IUCAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAARY3BydAAAAVAAAAAzZGVzYwAAAYQAAABsd3RwdAAAAfAAAAAUYmtwdAAAAgQAAAAUclhZWgAAAhgAAAAUZ1hZWgAAAiwAAAAUYlhZWgAAAkAAAAAUZG1uZAAAAlQAAABwZG1kZAAAAsQAAACIdnVlZAAAA0wAAACGdmlldwAAA9QAAAAkbHVtaQAAA/gAAAAUbWVhcwAABAwAAAAkdGVjaAAABDAAAAAMclRSQwAABDwAAAgMZ1RSQwAABDwAAAgMYlRSQwAABDwAAAgMdGV4dAAAAABDb3B5cmlnaHQgKGMpIDE5OTggSGV3bGV0dC1QYWNrYXJkIENvbXBhbnkAAGRlc2MAAAAAAAAAEnNSR0IgSUVDNjE5NjYtMi4xAAAAAAAAAAAAAAASc1JHQiBJRUM2MTk2Ni0yLjEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFhZWiAAAAAAAADzUQABAAAAARbMWFlaIAAAAAAAAAAAAAAAAAAAAABYWVogAAAAAAAAb6IAADj1AAADkFhZWiAAAAAAAABimQAAt4UAABjaWFlaIAAAAAAAACSgAAAPhAAAts9kZXNjAAAAAAAAABZJRUMgaHR0cDovL3d3dy5pZWMuY2gAAAAAAAAAAAAAABZJRUMgaHR0cDovL3d3dy5pZWMuY2gAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAZGVzYwAAAAAAAAAuSUVDIDYxOTY2LTIuMSBEZWZhdWx0IFJHQiBjb2xvdXIgc3BhY2UgLSBzUkdCAAAAAAAAAAAAAAAuSUVDIDYxOTY2LTIuMSBEZWZhdWx0IFJHQiBjb2xvdXIgc3BhY2UgLSBzUkdCAAAAAAAAAAAAAAAAAAAAAAAAAAAAAGRlc2MAAAAAAAAALFJlZmVyZW5jZSBWaWV3aW5nIENvbmRpdGlvbiBpbiBJRUM2MTk2Ni0yLjEAAAAAAAAAAAAAACxSZWZlcmVuY2UgVmlld2luZyBDb25kaXRpb24gaW4gSUVDNjE5NjYtMi4xAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAB2aWV3AAAAAAATpP4AFF8uABDPFAAD7cwABBMLAANcngAAAAFYWVogAAAAAABMCVYAUAAAAFcf521lYXMAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAKPAAAAAnNpZyAAAAAAQ1JUIGN1cnYAAAAAAAAEAAAAAAUACgAPABQAGQAeACMAKAAtADIANwA7AEAARQBKAE8AVABZAF4AYwBoAG0AcgB3AHwAgQCGAIsAkACVAJoAnwCkAKkArgCyALcAvADBAMYAywDQANUA2wDgAOUA6wDwAPYA+wEBAQcBDQETARkBHwElASsBMgE4AT4BRQFMAVIBWQFgAWcBbgF1AXwBgwGLAZIBmgGhAakBsQG5AcEByQHRAdkB4QHpAfIB+gIDAgwCFAIdAiYCLwI4AkECSwJUAl0CZwJxAnoChAKOApgCogKsArYCwQLLAtUC4ALrAvUDAAMLAxYDIQMtAzgDQwNPA1oDZgNyA34DigOWA6IDrgO6A8cD0wPgA+wD+QQGBBMEIAQtBDsESARVBGMEcQR+BIwEmgSoBLYExATTBOEE8AT+BQ0FHAUrBToFSQVYBWcFdwWGBZYFpgW1BcUF1QXlBfYGBgYWBicGNwZIBlkGagZ7BowGnQavBsAG0QbjBvUHBwcZBysHPQdPB2EHdAeGB5kHrAe/B9IH5Qf4CAsIHwgyCEYIWghuCIIIlgiqCL4I0gjnCPsJEAklCToJTwlkCXkJjwmkCboJzwnlCfsKEQonCj0KVApqCoEKmAquCsUK3ArzCwsLIgs5C1ELaQuAC5gLsAvIC+EL+QwSDCoMQwxcDHUMjgynDMAM2QzzDQ0NJg1ADVoNdA2ODakNww3eDfgOEw4uDkkOZA5/DpsOtg7SDu4PCQ8lD0EPXg96D5YPsw/PD+wQCRAmEEMQYRB+EJsQuRDXEPURExExEU8RbRGMEaoRyRHoEgcSJhJFEmQShBKjEsMS4xMDEyMTQxNjE4MTpBPFE+UUBhQnFEkUahSLFK0UzhTwFRIVNBVWFXgVmxW9FeAWAxYmFkkWbBaPFrIW1hb6Fx0XQRdlF4kXrhfSF/cYGxhAGGUYihivGNUY+hkgGUUZaxmRGbcZ3RoEGioaURp3Gp4axRrsGxQbOxtjG4obshvaHAIcKhxSHHscoxzMHPUdHh1HHXAdmR3DHeweFh5AHmoelB6+HukfEx8+H2kflB+/H+ogFSBBIGwgmCDEIPAhHCFIIXUhoSHOIfsiJyJVIoIiryLdIwojOCNmI5QjwiPwJB8kTSR8JKsk2iUJJTglaCWXJccl9yYnJlcmhya3JugnGCdJJ3onqyfcKA0oPyhxKKIo1CkGKTgpaymdKdAqAio1KmgqmyrPKwIrNitpK50r0SwFLDksbiyiLNctDC1BLXYtqy3hLhYuTC6CLrcu7i8kL1ovkS/HL/4wNTBsMKQw2zESMUoxgjG6MfIyKjJjMpsy1DMNM0YzfzO4M/E0KzRlNJ402DUTNU01hzXCNf02NzZyNq426TckN2A3nDfXOBQ4UDiMOMg5BTlCOX85vDn5OjY6dDqyOu87LTtrO6o76DwnPGU8pDzjPSI9YT2hPeA+ID5gPqA+4D8hP2E/oj/iQCNAZECmQOdBKUFqQaxB7kIwQnJCtUL3QzpDfUPARANER0SKRM5FEkVVRZpF3kYiRmdGq0bwRzVHe0fASAVIS0iRSNdJHUljSalJ8Eo3Sn1KxEsMS1NLmkviTCpMcky6TQJNSk2TTdxOJU5uTrdPAE9JT5NP3VAnUHFQu1EGUVBRm1HmUjFSfFLHUxNTX1OqU/ZUQlSPVNtVKFV1VcJWD1ZcVqlW91dEV5JX4FgvWH1Yy1kaWWlZuFoHWlZaplr1W0VblVvlXDVchlzWXSddeF3JXhpebF69Xw9fYV+zYAVgV2CqYPxhT2GiYfViSWKcYvBjQ2OXY+tkQGSUZOllPWWSZedmPWaSZuhnPWeTZ+loP2iWaOxpQ2maafFqSGqfavdrT2una/9sV2yvbQhtYG25bhJua27Ebx5veG/RcCtwhnDgcTpxlXHwcktypnMBc11zuHQUdHB0zHUodYV14XY+dpt2+HdWd7N4EXhueMx5KnmJeed6RnqlewR7Y3vCfCF8gXzhfUF9oX4BfmJ+wn8jf4R/5YBHgKiBCoFrgc2CMIKSgvSDV4O6hB2EgITjhUeFq4YOhnKG14c7h5+IBIhpiM6JM4mZif6KZIrKizCLlov8jGOMyo0xjZiN/45mjs6PNo+ekAaQbpDWkT+RqJIRknqS45NNk7aUIJSKlPSVX5XJljSWn5cKl3WX4JhMmLiZJJmQmfyaaJrVm0Kbr5wcnImc951kndKeQJ6unx2fi5/6oGmg2KFHobaiJqKWowajdqPmpFakx6U4pammGqaLpv2nbqfgqFKoxKk3qamqHKqPqwKrdavprFys0K1ErbiuLa6hrxavi7AAsHWw6rFgsdayS7LCszizrrQltJy1E7WKtgG2ebbwt2i34LhZuNG5SrnCuju6tbsuu6e8IbybvRW9j74KvoS+/796v/XAcMDswWfB48JfwtvDWMPUxFHEzsVLxcjGRsbDx0HHv8g9yLzJOsm5yjjKt8s2y7bMNcy1zTXNtc42zrbPN8+40DnQutE80b7SP9LB00TTxtRJ1MvVTtXR1lXW2Ndc1+DYZNjo2WzZ8dp22vvbgNwF3IrdEN2W3hzeot8p36/gNuC94UThzOJT4tvjY+Pr5HPk/OWE5g3mlucf56noMui86Ubp0Opb6uXrcOv77IbtEe2c7ijutO9A78zwWPDl8XLx//KM8xnzp/Q09ML1UPXe9m32+/eK+Bn4qPk4+cf6V/rn+3f8B/yY/Sn9uv5L/tz/bf//"},"featureLog":{"features":[{"name":"HW_COMPOSITING","description":"Compositing","status":"available","log":[{"type":"default","status":"available"}]},{"name":"D3D11_COMPOSITING","description":"Direct3D11 Compositing","status":"available","log":[{"type":"default","status":"available"}]},{"name":"DIRECT2D","description":"Direct2D","status":"available","log":[{"type":"default","status":"available"}]},{"name":"D3D11_HW_ANGLE","description":"Direct3D11 hardware ANGLE","status":"available","log":[{"type":"default","status":"available"}]},{"name":"GPU_PROCESS","description":"GPU Process","status":"available","log":[{"type":"default","status":"available"}]},{"name":"WEBRENDER","description":"WebRender","status":"available","log":[{"type":"default","status":"opt-in","message":"WebRender is an opt-in feature"},{"type":"user","status":"available","message":"Force enabled by envvar"}]},{"name":"WEBRENDER_QUALIFIED","description":"WebRender qualified","status":"blocked-device-too-old","log":[{"type":"default","status":"available"},{"type":"env","status":"blocked-device-too-old","message":"Device too old"}]},{"name":"OMTP","description":"Off Main Thread Painting","status":"available","log":[{"type":"default","status":"available"}]},{"name":"ADVANCED_LAYERS","description":"Advanced Layers","status":"available","log":[{"type":"default","status":"available"}]}],"fallbacks":[]},"crashGuards":[]},"extensions":[{"name":"Google","version":"1.0","isActive":true,"id":"google@search.mozilla.org"},{"name":"Session Restore Startup Performance Test","version":"2.1","isActive":true,"id":"session-restore-test-2@mozilla.org"},{"name":"Talos Powers","version":"1.1","isActive":true,"id":"talos-powers@mozilla.org"}],"features":[{"name":"Firefox Monitor","version":"3.0","id":"fxmonitor@mozilla.org"},{"name":"Firefox Screenshots","version":"39.0.0","id":"screenshots@mozilla.org"},{"name":"Form Autofill","version":"1.0","id":"formautofill@mozilla.org"},{"name":"Web Compat","version":"4.3.0","id":"webcompat@mozilla.org"},{"name":"WebCompat Reporter","version":"1.1.0","id":"webcompat-reporter@mozilla.org"}]}JavaScript error: resource://gre/modules/sessionstore/PrivacyFilter.jsm, line 117: TypeError: tab is undefined
19:59:26 INFO - [Child 6712, Chrome_ChildThread] WARNING: pipe error: 109: file z:/task_1559838951/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
19:59:26 INFO - [Child 2736, Chrome_ChildThread] WARNING: pipe error: 109: file z:/task_1559838951/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
19:59:26 INFO - [Child 2736, Chrome_ChildThread] WARNING: pipe error: 109: file z:/task_1559838951/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
19:59:26 INFO - [GFX1-]: Failed to connect WebRenderBridgeChild.

Flags: needinfo?(kmaglione+bmo)
https://hg.mozilla.org/integration/mozilla-inbound/rev/2983751114de7a26f6d509b7369c129baee5ac69
Bug 1555632: Add separate AddonManager.beforeShutdown barrier and use where appropriate. r=aswan
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Assignee: nobody → kmaglione+bmo

thanks for the patch. there are no crashes reported anymore in the most recent nightly builds containing the fix (yet).
could you request an uplift to beta, if you deem fit to so?

Flags: needinfo?(kmaglione+bmo)

(In reply to [:philipp] from comment #6)

thanks for the patch. there are no crashes reported anymore in the most recent nightly builds containing the fix (yet).
could you request an uplift to beta, if you deem fit to so?

Flags: needinfo?(jmathies)
Flags: needinfo?(ddurst)

Comment on attachment 9068804 [details]
Bug 1555632: Add separate AddonManager.beforeShutdown barrier and use where appropriate. r=aswan

Beta/Release Uplift Approval Request

  • User impact if declined: shutdown problems with addons
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1555632
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Minimal patch that improves AddonManager.shutdown related event handling. Authored by Kris, approved by aswan. In tree since June 7th. Test coverage included.
  • String changes made/needed:
Flags: needinfo?(jmathies)
Attachment #9068804 - Flags: approval-mozilla-beta?
Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(ddurst)

Comment on attachment 9068804 [details]
Bug 1555632: Add separate AddonManager.beforeShutdown barrier and use where appropriate. r=aswan

68 is in RC now, moving the approval request accordingly.

Attachment #9068804 - Flags: approval-mozilla-release?
Attachment #9068804 - Flags: approval-mozilla-esr68?
Attachment #9068804 - Flags: approval-mozilla-beta?

Comment on attachment 9068804 [details]
Bug 1555632: Add separate AddonManager.beforeShutdown barrier and use where appropriate. r=aswan

fix for shutdown hangs in addons manager, approved for 68 rc2

Attachment #9068804 - Flags: approval-mozilla-release?
Attachment #9068804 - Flags: approval-mozilla-release+
Attachment #9068804 - Flags: approval-mozilla-esr68?
Attachment #9068804 - Flags: approval-mozilla-esr68+

(In reply to Jim Mathies [:jimm] from comment #8)

  • Is this code covered by automated tests?: Yes
  • Needs manual test from QE?: No

Marking this as qe-verify- per Jim' assessment.

Flags: qe-verify-

the patch seems to have moved the crash to the [@ AsyncShutdownTimeout | AddonManager: Waiting to start provider shutdown. | EnvironmentAddonBuilder] signature (also see bug 1513855).

See Also: → 1513855
You need to log in before you can comment on or make changes to this bug.